Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension doesn't work due to the command is not pass as a string #8922

Closed
2 tasks done
linsui opened this issue Jun 23, 2022 · 1 comment · Fixed by #8923
Closed
2 tasks done

Extension doesn't work due to the command is not pass as a string #8922

linsui opened this issue Jun 23, 2022 · 1 comment · Fixed by #8923
Labels
bug Confirmed bugs or reports that are very likely to be bugs import

Comments

@linsui
Copy link
Contributor

linsui commented Jun 23, 2022

JabRef version

5.6 (latest release)

Operating system

GNU / Linux

Details on version and operating system

NixOS

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Import an entry from a browser.
  2. 2 Nothing happens.

Appendix

In

jabref/buildres/linux/jabrefHost.py

Line 77 in 3c2aae9

cmd = str(JABREF_PATH).split() + ["--importBibtex", r"{}".format(data)]
the data is passed directly. When there is space in data then it will be parsed as multiple strings. The fix is simple, i.e. change it to r"'{}'".format(data), as posted in NixOS/nixpkgs#162593 (comment), thanks to @koschtschei.
@Siedlerchr
Copy link
Member

@linsui Thanks for the feedback! Feel free to create a PR to fix this

@linsui linsui mentioned this issue Jun 23, 2022
Merged
6 tasks
@ThiloteE ThiloteE added the bug Confirmed bugs or reports that are very likely to be bugs label Jun 23, 2022
Siedlerchr pushed a commit that referenced this issue Jun 23, 2022
@linsui
Pass the data as a string (#8923)
0c96007 
closes #8922
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs import
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass the data as a string for the browser extension
3 participants
@Siedlerchr @linsui @ThiloteE