Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show social links in menu bar #8774

Closed
claell opened this issue May 9, 2022 · 11 comments
Closed

Don't show social links in menu bar #8774

claell opened this issue May 9, 2022 · 11 comments
Assignees
Labels

Comments

@claell
Copy link
Contributor

claell commented May 9, 2022

Is your suggestion for improvement related to a problem? Please describe.
When first using JabRef, I was slightly annoyed (yes, that is how it felt to me) by the social buttons inside the main menu bar. This does not look very professional to me and might consume useful space on smaller displays.

Describe the solution you'd like
Remove them by default, possibly add an option to show them again in case somebody wants them to be displayed there.

Additional context
grafik

@ThiloteE
Copy link
Member

ThiloteE commented May 9, 2022

On my small screen these buttons are actually the ones outside my screen:

grafik

Nice! :-)

but yes, I agree, they could potentially be inside the "help" menu.

@ThiloteE ThiloteE added the ui label May 9, 2022
@claell
Copy link
Contributor Author

claell commented May 10, 2022

They already seem to be inside the help menu (JabRef resources).

@Beingmani
Copy link

Beingmani commented May 11, 2022

This seems to be a good first issue and I'm interested in working on this, can I give a shot?

if we fix this, probably #8781 will also be fixed. Seems like we already have them in the Help Menu, Removing them from the tool bar would be a good solution for the small size window issues.

image

@claell
Copy link
Contributor Author

claell commented May 11, 2022

@Beingmani thanks for your interest in this.

I assume, that you can start working on this. Ideally, create a draft PR, so you can get early feedback and others are aware that you are working on it (apart from assigning you to this issue).

@ThiloteE
Copy link
Member

Thank you Beingnami :-)

As a general advise: check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

@Css22
Copy link
Contributor

Css22 commented May 15, 2022

That sounds interesting, and I'd like to try deleting it straight away. It doesn't seem too difficult. Can I have a try?

@Beingmani
Copy link

Hey, @Css22 I've already worked on it and will be raising a PR soon.

I've fixed it and made a few changes with the CSS which will fix this issue.

@Css22
Copy link
Contributor

Css22 commented May 15, 2022

Sorry, I just saw it. I will not continue to work for this issue. I have made some changes to the DOI that I hope will help you @Beingmani.

@calixtus
Copy link
Member

Thanks for your interest in JabRef, we'll discuss your proposal to remove the social tool bar buttons in the next devcall.

Beingmani added a commit to Beingmani/jabref that referenced this issue May 16, 2022
koppor added a commit that referenced this issue May 23, 2022
Co-authored-by: Christoph <[email protected]>
Co-authored-by: ThiloteE <[email protected]>
Co-authored-by: Benedikt Tutzer <[email protected]>
Co-authored-by: Oliver Kopp <[email protected]>
@ThiloteE
Copy link
Member

ThiloteE commented May 23, 2022

In the devcall, we decided to move forward with a less intrusive solution of #8798. That solution works perfect in window sizes equal to 1280x960 or bigger than that. For smaller window sizes, some buttons will only show via clicking on the arrow at the right side, starting with Github.

@claell
Copy link
Contributor Author

claell commented Jun 13, 2022

Alright, that is at least an improvement :) I guess that I can live with that, as there always needs to be a compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants