Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author surnames starting with a lower case letter disappear in citation key #8601

Closed
2 tasks done
RonMcKay opened this issue Mar 23, 2022 · 2 comments · Fixed by #8634
Closed
2 tasks done

Author surnames starting with a lower case letter disappear in citation key #8601

RonMcKay opened this issue Mar 23, 2022 · 2 comments · Fixed by #8634
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator

Comments

@RonMcKay
Copy link

JabRef version

5.5 (latest release)

Operating system

Windows

Details on version and operating system

JabRef 5.5--2022-01-17--27a05c7 Windows 10 10.0 amd64 Java 16.0.2 JavaFX 17.0.1+1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Set the default pattern of the Citation key pattern to [auth][year]
  2. Add an article with a first author who's surname starts with a lower case letter (e.g. https://arxiv.org/abs/2103.10697) or edit an existing article so that the first letter of the first author's surname is lower case.
  3. Hit 'Generate citation key' -> 'Overwrite keys'

The resulting Citation key is missing the [auth] field and is just displaying the year.

Appendix

No response
@mlep
Copy link
Contributor

mlep commented Mar 23, 2022

Confirmed in JabRef 5.6--2022-03-21--b47c29f
Linux 4.19.0-19-amd64 amd64
Java 17.0.2
JavaFX 18+12

@Siedlerchr
Copy link
Member

I dug a bit into it. JabRef parses the first author Stéphane d'Ascoli into firstname + vonPart . So far so correct.
The [auth] patterns only returns the last name, it does not consider the von-Part. That is only considered when using
[authFirstFull].
In contrast, an author like Michiel van den Brekel is generated correctly. Breken is identified as lastname.
However, with [authFirstFull] you would get vandenBrekel2021

A possible solution would be to return the vonPart (if any) in case the lastname is empty.

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Apr 1, 2022
Siedlerchr added a commit that referenced this issue Apr 1, 2022
@Siedlerchr
Citation keygen: Return vonPart if lastName is empty
853834b 
Fixes #8601
@Siedlerchr Siedlerchr mentioned this issue Apr 1, 2022
Merged
6 tasks
Siedlerchr added a commit that referenced this issue Apr 2, 2022
@Siedlerchr
Citation keygen: Return vonPart if lastName is empty (#8634)
41bd5e0 
* Citation keygen: Return vonPart if lastName is empty

Fixes #8601

* changelog and checkstyle
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Citation keygen: Return vonPart if lastName is empty JabRef/jabref
3 participants
@Siedlerchr @mlep @RonMcKay