Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private fields (and other field flags) #850

Closed
koppor opened this issue Feb 20, 2016 · 2 comments
Closed

Remove private fields (and other field flags) #850

koppor opened this issue Feb 20, 2016 · 2 comments
Labels
type: code-quality Issues related to code or architecture decisions type: enhancement

Comments

@koppor
Copy link
Member

koppor commented Feb 20, 2016

Private fields (fields marked with net.sf.jabref.gui.InternalBibtexFields.BibtexSingleField.PRIVATE), seem to be fields introduced by JabRef itself. For instance, owner and timestamp. There are also fields such as entrytype, which seem to be deprecated or can be removed.

Proposal: Introduce "JabRef fields" (owner, timestamp, maybe special fields (refs JabRef#84), ...) and move the other fields (type, bibtexkey, ...) as properties of BibEntry

We have to get rid of the private flag and make use of the displayable and writable flag only. These flags are required for the current implementation of special fields.

Alternatively, we can get rid of displayable and writable and use private for fields neither displayable nor writable (only required for special fields when stored in keywords; when written as separate fields, they are non-private and handled normally).

Even better, not misusing bibtex fields at all. Regarding the current implementation of special fields, it might be impossible to do so without changing the special fields implementation. See JabRef#84.

Refs #574

@koppor koppor changed the title Rethink private fields Remove private fields (and other field flags) Mar 16, 2016
@lenhard lenhard added type: enhancement type: code-quality Issues related to code or architecture decisions labels Jul 29, 2016
@stefan-kolb stefan-kolb added jabcon and removed jabcon labels Aug 23, 2019
@stefan-kolb
Copy link
Member

@JabRef/developers Are these fields removed? I cannot find anything anymore, when searching the code.

@Siedlerchr
Copy link
Member

You are right. This has been changed. We have clear enums for InternalField., SpecialField and normal Bibtex/Biblatex fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions type: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants