Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink implementation of special fields #84

Closed
koppor opened this issue Dec 5, 2015 · 4 comments
Closed

Rethink implementation of special fields #84

koppor opened this issue Dec 5, 2015 · 4 comments

Comments

@koppor
Copy link
Member

koppor commented Dec 5, 2015

Should special fields be implemented as a special kind of groups? See JabRef#363 (comment)

Pro:

  • Might offer to configure arbitrary special fields instead the hard-coded ones (ranking, priority, quality, ...)

Con:

  • Possibly, this causes too much effort in the UI (especially: table columns)
@tobiasdiez
Copy link
Member

I understand special fields as fields for which JabRef has some special handling. For example, support drop-down boxes with pre-defined values (e.g. reading status) or show nice icons (e.g. quality assured).
However, such actions can't be described by the user in a convenient way. Thus I would keep the current implementation.

@koppor
Copy link
Member Author

koppor commented Sep 12, 2016

Add a new kind of group - the special group. 😇 - It defines a list of possible values and icons for each value. If the group has one member only, it is a toggle thing (Printed). If it has more members, the other behavior (Prio) is done.

@oscargus
Copy link

While not so hard to add new fields, I do not really find it realistic to add user configurability. This is primarily said considering the UI. From some perspective one can already do something similar with custom fields and/or keywords, it is just the UI and the possibility to store the field automatically as a keyword that differs.

Not sure how things work right now, but one might think of adding some easy filtering/groups for the special fields, so a dynamic group with the field icons etc.

Finally, I haven't really looked at the code more than from the perspective of separating things. Turned out it wasn't so easy because of SpecialFieldValue (or rather, the current implementation is actually quite nice, except for the separation issue).

@koppor
Copy link
Member Author

koppor commented Sep 13, 2016

devcall decision: leave as is

@koppor koppor closed this as completed Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants