Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using master of forks is dangeours #6699

Closed
koppor opened this issue Jul 19, 2020 · 1 comment · Fixed by #6708
Closed

Using master of forks is dangeours #6699

koppor opened this issue Jul 19, 2020 · 1 comment · Fixed by #6708

Comments

@koppor
Copy link
Member

koppor commented Jul 19, 2020

  1. We update master in a GitHub actions "cron job".
  2. The master of forks is also updated
  3. The updates of the forks do NOT happen at the same time
  4. That leads to different commit ids at each master branch
  5. That leads to strange pull requests, when conributors merge master instead of upstream/master (strange behavior e.g. at mEDRA DOI fetcher implementation. #6641 (comment) and Add testing interface, including a set of capabilities to tests for #6687 (review))

Solution possibilities:

  1. Guard the GitHub action by checking whether we are on JabRef/jabref
  2. Have the CSL update happening at another branch and merge the branch using a pull request to our GitHub repository
  3. Ensure that all documantation says upstream/master - also in our manual pull request comments.

Think, we should go for option 1, since we cannot ensure that all references to master are prefixed by upstream/master.

@Siedlerchr
Copy link
Member

Something like this should work: if: github.repository == ‘JabRef/jabref’

Siedlerchr added a commit that referenced this issue Jul 26, 2020
koppor pushed a commit that referenced this issue Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants