Failing architecture tests

[koppor]

Just as to remind that this is known, but not yet fixed.

We cannot fix it today, but hopefully a PR will come in soon.

Test 10 -- is org.jabref.model independent of org.jabref.logic? FAILED

  org.opentest4j.AssertionFailedError: The following classes are not allowed to depend on org.jabref.logic ==> expected: <[]> but was: <[src/main/java/org/jabref/model/cleanup/NormalizeNewlinesFormatter.java]>
      at [email protected]/org.jabref.architecture.MainArchitectureTests.firstPackageIsIndependentOfSecondPackage(MainArchitectureTests.java:110)

[Siedlerchr]

It depends on OS.newline which is in logic. Need to move OS to model as well

[Siedlerchr]

Argh. It depends on l10n which is also in logic. Should I add an exception for this case?
I know the reason for our architecture, but due to one instanceof check I already had to move OS and NormalizeCleanupFormatter down to model.

Edit// I can get rid of the l10n. It's an internal formatter only

[koppor]

Please try to keep model with inbound dependencies only. This allows for offering JabRef as a programming library.

[koppor]

I tried to dig down the root cause:

• 1a43290 move formatter down to model. Did this happen directly in the master branch? There is no PR linked from the commit.
• The call to NormalizeNewlinesFormatter was introduced in Additional check if values have changed in bindToEntry #6528 by @calixtus to fix Cursors jumps to the beginning #5904.

Notes

• public abstract class Formatter { was always in org.jabref.model.cleanup. I always felt is trange that the abstract interface is is model, but the implementation in logic. There is no ADR for this
• FieldFormatterCleanup seems to be in the model packge sind ages.

[Siedlerchr]

#6717 (comment)