Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file save does not work when editing bib code in entry editor #6622

Closed
ilippert opened this issue Jun 19, 2020 · 13 comments · Fixed by #7116
Closed

file save does not work when editing bib code in entry editor #6622

ilippert opened this issue Jun 19, 2020 · 13 comments · Fixed by #7116
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor

Comments

@ilippert
Copy link
Contributor

JabRef 5.1--2020-06-13--0432100
Linux 5.6.18-300.fc32.x86_64 amd64
Java 14.0.1

Steps to reproduce the behavior:

  1. edit an entry in the source field within the entry editor
  2. press ctrl+s
  3. close file
  4. open file

Effect: the final change was not saved.
it gets saved when the user shifts to another field of the entry editor and then presses ctrl+2.
@ilippert ilippert changed the title file save does not work when editing bob code in entry editor file save does not work when editing bib code in entry editor Jun 22, 2020
@DaniloMurer
Copy link

Has anyone picked this issue up? If not I'd like to give it a try.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 14, 2020 •
edited
Loading

@DaniloMurer You can take a look at it. But be warned that the source code editor tab is a complex issue and modications can produce nasty side effects. The code is in gui/entryeditor/SourceTab,java.
I guess it's related to the focusedPropertyListener which store the source when the focus is changed

@DaniloMurer
Copy link

Ok thanks for the advice and the warning. I'm going to try my best maybe I can find a solution to this.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 14, 2020 •
edited
Loading

Feel free to ask here or in the developer gitter channel. You might want to read the contribution guide for our contribution process
https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md

@DaniloMurer
Copy link

Ok thank you very much. I got it how to make the branch so that's not a problem anymore.

Greetings

@Siedlerchr
Copy link
Member

Is this still a problem?

@ilippert
Copy link
Contributor Author

ilippert commented Sep 1, 2020 via email

@DaniloMurer
Copy link

Hello, yes the issue does still persist and I'm not sure if I've got enough free time to fix this issue.

Regards

@ilippert
Copy link
Contributor Author

ilippert commented Sep 1, 2020

JabRef 5.2--2020-09-01--35f5078
Linux 5.8.4-200.fc32.x86_64 amd64
Java 14.0.2

problem persists.

@ilippert
Copy link
Contributor Author

JabRef 5.2--2020-11-21--b0af521
Linux 5.9.8-200.fc33.x86_64 amd64
Java 15.0.1

problem persists.

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Nov 22, 2020
Siedlerchr added a commit that referenced this issue Nov 22, 2020
@Siedlerchr
Fix saving in codeArea without leaving the field
6c3bff8 
Refactor  globals

fixes #6622
@Siedlerchr Siedlerchr mentioned this issue Nov 22, 2020
Merged
5 tasks
@Siedlerchr
Copy link
Member

This issue should now be resolved in latest master.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@ilippert
Copy link
Contributor Author

JabRef 5.2--2020-11-23--350ec1f
Linux 5.9.9-200.fc33.x86_64 amd64
Java 15.0.1

Hi, in this version, when I edit the bib code directly, it takes some seconds until the * appears next the the library's name, indicating the unsaved change of the file.

@ilippert
Copy link
Contributor Author

But saving now works- thanks!

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
koppor pushed a commit that referenced this issue Aug 15, 2023
Squashed 'buildres/csl/csl-styles/' changes from 0749a19b83..795ad0c772
3efeba7 
795ad0c772 Create duale-hochschule-baden-wurttemberg-department-of-international… (#6622)
18ee055259 Create Howard Hughes Medical Institute  (#6615)
ad5bedc1d2 Update the-journal-of-clinical-investigation.csl (#6607)
6a938ccd0e Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6621)
289fda356b Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6620)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 795ad0c77258cb7e01f3413123b5b556b4cb6a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix saving in codeArea without leaving the field JabRef/jabref
3 participants
@Siedlerchr @ilippert @DaniloMurer