Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select library during import #6177

Closed
jorgman1 opened this issue Mar 25, 2020 · 11 comments · Fixed by #9402
Closed

Select library during import #6177

jorgman1 opened this issue Mar 25, 2020 · 11 comments · Fixed by #9402
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. import type: enhancement ui

Comments

@jorgman1
Copy link

Would it be possible to select the library into which the entry is imported?

I often have several libraries open at the same time, and I have to switch to the desired library before importing (something that I often forget).

@tobiasdiez tobiasdiez transferred this issue from JabRef/JabRef-Browser-Extension Mar 25, 2020
@jorgman1
Copy link
Author

jorgman1 commented Dec 9, 2020

issue is still relevant

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: stale labels Dec 9, 2020
@JofielB
Copy link
Contributor

JofielB commented Dec 15, 2020

Hello, just to be sure the desire solution would be something like this:

  1. create or open at least 2 libraries
  2. Make a web search for anything
  3. Select 1 or more things you want to important
  4. Start importing
  5. A dialog view appears and asks you in which library you want to make the imports (solution)
  6. The imports are done

@jorgman1
Copy link
Author

Something like that. The button to select the library could be in the current import window. It is large. Or it could be a dropdown list.

@JofielB
Copy link
Contributor

JofielB commented Dec 18, 2020

Nice, I am gonna try to add that dropdown to the Import window

@JofielB
Copy link
Contributor

JofielB commented Dec 23, 2020

I don't gonna be able to continue working on this issue but for the ones that may take this issue in the future I will leave the following tips:

  • You can change the import window design to add the dropdown at this file: ImportEntriesDialog.fxml
  • The ImportEntriesDialog.fxml has assigned the ImportEntriesDialog.java as a controller
  • Another import file to check is the ImportEntriesViewModel.java
  • Read how the MVVM pattern works to understand how the: ImportEntriesDialog.fxml, ImportEntriesDialog.java and the ImportEntriesViewModel.java files are connected

@mohit038-zz
Copy link
Contributor

I think fixing this issue will create another issue related to duplicate entries. Bc in the current implementation, after fetching data from the web, jabref compares those imported entries with the current context to find duplicates. If you change the library after the import, it has to compare it again, and also if the newly selected library has groups, then In which group entries should be imported.

Screenshot 2021-04-02 at 7 46 55 AM

@tp-1000
Copy link
Contributor

tp-1000 commented Apr 2, 2021

@mohit038 I think you're right. I don't know how implementation would be but what about at least adding an undo to recover from a bad import??

@mohit038-zz
Copy link
Contributor

@tp-1000 That's a really good idea. How about adding an undo button in the toast message.

Screenshot 2021-04-02 at 12 29 12 PM

@tp-1000
Copy link
Contributor

tp-1000 commented Apr 2, 2021

@mohit038 Seems like if it was set up to handle undo it would make sense to take advantage of the existing architecture – the mainMenu or Keyshort cut. Toast only last so long and could be missed.

@ThiloteE ThiloteE moved this to Free to take in Good First Issues Oct 14, 2022
@koppor koppor moved this to Normal priority in Features & Enhancements Nov 7, 2022
@JabRef JabRef deleted a comment from github-actions bot Nov 17, 2022
calixtus pushed a commit that referenced this issue Dec 19, 2022
Co-authored-by: Carl Christian Snethlage <[email protected]>
Co-authored-by: Siedlerchr <[email protected]>
Fixes #6177
Repository owner moved this from Free to take to Done in Good First Issues Dec 19, 2022
Repository owner moved this from Normal priority to Done in Features & Enhancements Dec 19, 2022
@Siedlerchr
Copy link
Member

@jorgman1 Thanks to the work from @MaryJml it is now implemented in the latest development version (6.0) https://builds.jabref.org/main/
and will be ready in roughly 20 minutes

@jorgman1
Copy link
Author

Thank you very much. It works like a charm! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. import type: enhancement ui
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants