Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File / Import / Append library freezes JabRef #6049

Closed
1 task done
calixtus opened this issue Mar 1, 2020 · 7 comments · Fixed by #6184
Closed
1 task done

File / Import / Append library freezes JabRef #6049

calixtus opened this issue Mar 1, 2020 · 7 comments · Fixed by #6184
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@calixtus
Copy link
Member

calixtus commented Mar 1, 2020

JabRef version 100.0.0 (current master 2020-03-01 14:00 PM) on Windows 10

Steps to reproduce the behavior:

  1. Open one library.
  2. In the menu open file -> Append library
  3. Check import entries
  4. Select another library
@Siedlerchr
Copy link
Member

I think we also need to show a progresbar

@koppor koppor added the bug Confirmed bugs or reports that are very likely to be bugs label Mar 3, 2020
@koppor koppor added this to the v5.1 milestone Mar 3, 2020
@koppor
Copy link
Member

koppor commented Mar 3, 2020

Similar issue: When opening a large library, JabRef takes much time to load. @tobiasdiez Will open an issue with "pain points"

@fanmingyu212
Copy link

Can also confirm the same issue with both JabRef 5.0 (public release version) and 5.1 (current master, acf2ac4) on "Windows 10 10.0 amd64, Java 14"

@calixtus
Copy link
Member Author

I'm not sure what the difference between AppendDatabaseAction and ImportAction into current Database is...

@koppor
Copy link
Member

koppor commented Mar 22, 2020

A quick look reveals following for me:

  • AppendDatabaseAction: org/jabref/gui/importer/actions/AppendDatabaseAction.java:97 --> importGroups, which relies on the old group format
  • I forgot about the ContentSelector. This is somehow important - and not handled in the ImportAction (but in AppendDatabaseAction)
  • The ImportAction opens a dialog for selecting entries. - The "AppendDataBaseAction" should not ask for confirmation, but just do it.

We discussed on JabCon 2018 that we should not add popups, but do more "magic". Then, the dialog in ImportAction could be deleted.

We used to have "mark entries" in JabRef 2.x. This was removed, because we replaced it by groups - and the current JavaFX table cannot show entries not matched by a filter :-. -- This functionality comes into my mind, because we used to mark imported entries and moved them to the top of the entry table.

@calixtus
Copy link
Member Author

calixtus commented Mar 23, 2020

I was asking, because in JabRefFrame a comment is indicating that those two commands should be merged... (JabRefFrame.java:681)

The comment has been introduced with commit 2fc5a34 by @tobiasdiez ( #3684 ).

@tobiasdiez
Copy link
Member

Both actions are more or less the same (at least from a user perspective): Select a file and put everything contained in that file into the current library.

Usually, the import action "only" imports entries while the "append" also includes metadata (e.g. groups). In my opinion, they can indeed be merged.

koppor pushed a commit that referenced this issue May 15, 2022
649aac4 Create medizinische-hochschule-hannover.csl (#6059)
3723981 Remove bold from volume for Frontiers medical (#6060)
e6dc596 Update SBL 2nd ed. (Full Note) for 6.2.25 Electronic Book (#5808)
83140f6 Fix citation-format tag in BibTeX.CSL
0aa00e5 fixed edition macro (#6055)
a83c15c Fix year suffix for ASA (#6052)
cfadb19 Create journal-of-midwifery-science.csl (#6051)
88e4f34 Create journal-of-neuroimaging.csl (#6048)
ca57b27 Update american-chemical-society.csl for webpage (#6050)
94e2699 Update netherlands-journal-of-geosciences-geologie-en-mijnbouw.csl (#6049)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 649aac4
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants