Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File annotations should be parsed if a file is attached #5633

Closed
koppor opened this issue Nov 18, 2019 · 4 comments
Closed

File annotations should be parsed if a file is attached #5633

koppor opened this issue Nov 18, 2019 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor status: stale

Comments

@koppor
Copy link
Member

koppor commented Nov 18, 2019

If a new file is attached, the tab "File Annotations" should be shown immediately - and not at refocus.

Video:

jabref-rulez-2

In case one plays around with it - approx each second time, just a new entry is created instead of attaching the file.

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Nov 18, 2019
@Xuanxuan-Zou
Copy link

Xuanxuan-Zou commented May 7, 2020

Hi, we are interested in this issue.

We find a way to solve this problem, that is set the new entry after the file is attach.
It needs add one line code in

case MOVE:
LOGGER.debug("Mode MOVE"); // alt on win
importHandler.getLinker().moveFilesToFileDirAndAddToEntry(entry, files);
break;

Between line 283 and line 284, adding panel.getEntryEditor().setEntry(entry);

It works, but we are not sure whether it is a proper way.

@koppor
Copy link
Member Author

koppor commented May 7, 2020

Thank you for looking into this. it is very hard for us to really review it. Would it be possibility OK for you to create a pull request? This is our preffered and we'll established way to review even small changes!

Xuanxuan-Zou added a commit to Xuanxuan-Zou/jabref that referenced this issue May 8, 2020
@Xuanxuan-Zou
Copy link

I had created a draft pull request.
I am sorry for the misoperation coused by my unfamiliarity.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor status: stale
Projects
Archived in project
3 participants