-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry preview: Error while generating citation style #5622
Comments
Can confirm this. Think it is a follow up issue from #5585 Actual exception and stack trace.
|
After I deleted and readded the csl-locale submodule it works again for me when running from eclipse. |
@koppor what do you think about replacing the git submodules by git subtrees? Then we also don't run into these problems that some people are pushing changes to the submodule commit hash as part of PRs. |
Reading https://codewinsarguments.co/2016/05/01/git-submodules-vs-git-subtrees/ -- +1 for subtrees.
Should we go for the "squashed" history? --> https://stackoverflow.com/a/51774939/873282 --> "Alt Squashed history" |
Yes, squashed history sounds good (I don't think we care about the detailed changes to the style files). |
PR to switch to git subtrees created: #5647 |
Git subtrees fixed the thing with the missing resources. Now I get the following error in the portable version of JabRef with loading the csl:
|
Everything works if you run from code (Intellj). However, when using the installer I still have an empty list of citation styles in the preference dialog. |
When you run from installer or portable the exception above is logged on the console window behind JabRef. |
@michel-kraemer can you please have a look at this, as this seems to be a problem with citeproc 2.0. Thanks! |
This could be a solution? #5246 (comment) |
It seems to me @koppor I don't see how this could be a solution. By the way, there is a method called |
Oh, by the way, I'm currently working on a pure Java implementation of citeproc-java. It does not support all CSL features yet but it works OK most of the time already. If you're interested, I can publish a snapshot of citeproc-java. This should solve all problems related to Graal JavaScript or Nashorn, and it should improve performance by a magnitude. |
@michel-kraemer The only thing which comes to my minds is, do you have an (Automatic) Module name/manifest for citeproc-java? Maybe it's some modularity/classpath issue with jlink/jpackage. I think it's worth a try to test the snapshot of the pure java implementation |
@michel-kraemer Any news on this? We are planning a new release and it would be great to check if it works with a snapshot of your java implementation |
Works fine from current (19-feb-2020) code, if you build from code, as was pointed out by @tobiasdiez 6-dec-2019. 1: clone repo Source: Current development binary 5.0 does not work for me, with same error as before for APA and IEEE (internal view "preview" is fine). Development binary: |
Sorry for the delay. Sure, I can publish a new snapshot with the latest changes and make a pull request on the weekend, if that's fine with you. I'll keep you updated. |
I just created the pull request. The new pure-Java mode is super fast and seems to work well. Please note that the snapshot does not support all features of CSL yet (CSL is extremely complex to implement) but at least the most important ones (about 80-90% of the specification). I'm continuously working on improving the library and will release a final version 2.1.0 in the next couple of months. Also note that the snapshot supports text and HTML output only at the moment. I found a comment in the code of By the way, I also tried to fix the installer by adding the required modules to the jlink configuration in the |
Thanks @michel-kraemer, that are really good news! @koppor @Siedlerchr I tried this version (in the portable version) and the "Entry preview" panel in the preference is still empty for me, no citation styles are loaded. No error messages are logged. |
I did gradlew run and had a list of all citations in the JabRef preferences
to choose from.
Could you push the branch to our repo to trigger a binary build
nevertheless?
Tobias Diez <[email protected]> schrieb am Sa., 22. Feb. 2020, 20:09:
… Thanks @michel-kraemer <https://github.com/michel-kraemer>, that are
really good news!
@koppor <https://github.com/koppor> @Siedlerchr
<https://github.com/Siedlerchr> I tried this version (in the portable
version) and the "Entry preview" panel in the preference is still empty for
me, no citation styles are loaded. No error messages are logged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5622?email_source=notifications&email_token=AAKNU7XLWTJZVT4MZQ4FUOLREFZ43A5CNFSM4JOGEUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVIEUQ#issuecomment-589988434>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKNU7Q5KMTSUAYHMXUCUADREFZ43ANCNFSM4JOGEUCA>
.
|
That's strange. I tested it with |
I guess it's again a problem with the bundled/installed app. I've downloaded the windows builds from https://github.com/JabRef/jabref/actions/runs/43527976. The same problem occurs in the quite old build JabRef 5.0-beta.1--2019-12-15--0b8b1d6, so this appears not to be special for your PR. |
Question is, is it jlink or jpackage which has the bug? |
I'm pretty sure it's not a bug in jlink or jpackage but in our code. There is a difference in how resources are found in a local build (= they are just normal files and our FileSystem approach works) vs in a bundled build (=they are files in a jrt module and our FileSystem approach does not work). jabref/src/main/java/org/jabref/logic/citationstyle/CitationStyle.java Lines 146 to 159 in 1fd53bf
A possible solution is outlined here: #5246 (comment) |
@tobiasdiez I think I maybe found a solution. https://stackoverflow.com/a/54142975 |
Hopefully, this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version. |
Still present. Starting from the bat I now get a different error:
|
This new error does not seem to be JabRef related. I guess the error message points to this part @michel-kraemer you might want to consider adding the relevant statements from d2de477 to the usage notes of your nice |
@tobiasdiez The error message is misleading. I received the same error when I tried to integrate citeproc-java with GraalVM the first time into JabRef. I solved it by adding the required modules to the
Good idea, but I hope that I can completely get rid of GraalVM in the future when the new pure-Java implementation is ready. |
What I mean with "the error message is misleading": It is trying to load the regex extension of Graal JavaScript but cannot find the implementation classes. |
This issue should be fixed now in master. We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version. |
5facb37 Update soil-biology-and-biochemistry.csl (#5630) dba7c17 Change representation of locators (#5629) 38c5b99 change et-al settings (#5628) 634b5e0 Create netherlands-journal-of-geosciences.csl (#5624) fa2cce2 Create journal-of-information-literacy.csl (#5622) c0d2bf1 Add legislation to AZR & Austrian Legal (#5625) 9724c6e UACJ: Fix op. cit. b12f90f Update style-manual-australian-government.csl (#5603) 94dba2c Create sports-health.csl (#5620) 2ca5cd8 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5619) 32ef9ba Create annals-of-eye-science.csl (#5615) 928e5a6 Create journal-of-microbiology.csl (#5616) a829c84 Update harvard-cite-them-right-no-et-al.csl (#5617) 6182c7b Fix the right _St. York_ Harvard style 1454760 Fix York Harvard title d8c5cef Create harvard-cite-them-right-11.csl (#5612) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 5facb37
JabRef 5.0.0-dev--2019-11-16----3fbeef03d
Mac OS X 10.13.6 x86_64
Java 13.0.1
Steps to reproduce:
Jabref-5.0.0 has been in this state for a couple of development snapshots.
I have configured APA style, but I get the same "Error while generating citation style" with other styles. I get the same error for all entries in the bibliography.
The text was updated successfully, but these errors were encountered: