Highlight new entry in maintable

[tobiasdiez]

Is your suggestion for improvement related to a problem? Please describe.
When editing a new entry, the entry is not highlighted in the main table.

Describe the solution you'd like
Highlight the entry (in blue) as it is done when editing an existing entry.

[CaptainDaVinci]

I found that when a new entry is inserted in the database, the MainTableDataModel.entriesFiltered and MainTableDataModel.entriesSorted (MainTableDataModel) do not reflect those changes and the corresponding table entry is not selected.
I am not able to understand why the changes are not reflected, any pointers on how to proceed with this issue would be great! :)

Edit: The entriesViewModel does not reflect the database changes.

[tobiasdiez]

That's a bit strange. These properties should contain the new entry and I also suspect that it works as otherwise new entries wouldn't be shown in the main table.

The class MainTable has the following method

jabref/src/main/java/org/jabref/gui/maintable/MainTable.java

Lines 132 to 138 in 79f9c86

	public void clearAndSelect(BibEntry bibEntry) {
	findEntry(bibEntry).ifPresent(entry -> {
	getSelectionModel().clearSelection();
	getSelectionModel().select(entry);
	scrollTo(entry);
	});
	}

So in the end, you just need to call this method with the newly created entry.

[CaptainDaVinci]

The clearAndSelect method is being called when inserting a new entry,

jabref/src/main/java/org/jabref/gui/BasePanel.java

Line 628 in 79f9c86

clearAndSelect(bibEntry);

Maybe, the MappedList entriesViewModel is not working as intended?

[CaptainDaVinci]

@tobiasdiez the issue seems to be fixed in the latest master. The problem, I think, was with UiThreadList triggering the changes to allEntries on a different thread.

[tobiasdiez]

It indeed works as expected now!

[koppor]

Just for reference: This was also a feature request in 2008 for imported entries: https://sourceforge.net/p/jabref/bugs/650/