Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity check should not list "abbreviation detected" #3925

Closed
Sethur opened this issue Apr 4, 2018 · 10 comments · Fixed by #7208
Closed

Integrity check should not list "abbreviation detected" #3925

Sethur opened this issue Apr 4, 2018 · 10 comments · Fixed by #7208
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. integrity-checker type: enhancement

Comments

@Sethur
Copy link

Sethur commented Apr 4, 2018

Issue persists in latest dev master.

JabRef version 4.1 on Windows 7

Steps to reproduce:

  1. Perform integrity check on database with abbreviated (MEDLINE or ISO) journal entries
  2. There will be a warning for every abbreviated journal entry found

This should not be listed as an integrity problem since the current way JabRef handles common journal abbreviations is exactly by replacing the entire string in the Bib(La)Tex entry with the abbreviated one, so this behavior is expected.

Suggested solution: Scratch the integrity warning and replace the yellow warning icon when editing such entries with an info icon.

@Siedlerchr Siedlerchr added type: enhancement entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. integrity-checker labels Apr 5, 2018
@sudoxx2
Copy link

sudoxx2 commented Apr 6, 2018

Hello if this is up for grabs I would like to tackle it. Is there any more documentation on the issue that I can familiarize myself with?

@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 6, 2018

Hi, thanks for your interest!
You can have a look here to set up your workspace and the general workflow:
https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md

If you have futher questions, just ask us here or in our gitter chat at https://gitter.im/JabRef/jabref

@stefan-kolb stefan-kolb added this to the v4.3 milestone Apr 26, 2018
@Siedlerchr Siedlerchr removed this from the v4.4 milestone Oct 2, 2018
@Siedlerchr Siedlerchr added the hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. label Oct 2, 2018
@laolux
Copy link

laolux commented Oct 24, 2018

An additional issue which could be tackled in the same fix are journals where name and abbreviation are the same. For example the journal "Science" as abbreviated "Science" and therefore always gets listed as a problem during integrity check.

@dschrempf
Copy link
Contributor

Since I just wanted to file an issue, but found this one here: Has there been any progress made on this issue?

@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@THgithub19
Copy link

Science still gets a yellow warning mark in Jabref 5.1, issue not resolved.

@Siedlerchr Siedlerchr reopened this Oct 15, 2020
@koobs
Copy link

koobs commented Dec 20, 2020

Confirming issue on latest master

JabRef 5.2--2020-12-19--5aa896a
Windows 10 10.0 amd64 
Java 14.0.2

For the following journaltitles: Wear, Chemosphere, Energy Procedia, Aquaculture, Zebrafish

Siedlerchr added a commit that referenced this issue Dec 20, 2020
tobiasdiez pushed a commit that referenced this issue Dec 20, 2020
* Remove journal abbrev deteted in entry editor

Fixes  #3925

* add changelog
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@koobs
Copy link

koobs commented Dec 21, 2020

@tobiasdiez #6502 may be a dupe of this issue and/or #7208 may resolve it.

@koobs
Copy link

koobs commented Dec 22, 2020

@tobiasdiez Confirming resolution (see screenshot) on:

JabRef 5.2--2020-12-20--84c8504
Windows 10 10.0 amd64 
Java 14.0.2

2020-12-22 11_38_17-Integrity check should not list abbreviation detected · Issue #3925 · JabRef_j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. integrity-checker type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants