Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Native filedialogs (JavaFX only) #1711

Closed
2 tasks
Siedlerchr opened this issue Aug 10, 2016 · 6 comments
Closed
2 tasks

Support Native filedialogs (JavaFX only) #1711

Siedlerchr opened this issue Aug 10, 2016 · 6 comments

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 10, 2016

Currently the jFileChooser in Swing does not show a native file dialog.
However, JavaFX does.
With the new implementation in #1336 a further change is made easier.
Steps to consider:

  • Investigate if JavaFx FileChooser supports all relevant methods needed
  • Integration into Swing dialogs

http://docs.oracle.com/javafx/2/ui_controls/file-chooser.htm
http://javafxtuts.com/javafx-file-chooser/

Discussion why Swing does not support it:
http://stackoverflow.com/questions/5703825/does-swing-support-windows-7-style-file-choosers

@tobiasdiez
Copy link
Member

Good idea and should be definitely done (after migration to javafx happened).

@jdpipe
Copy link

jdpipe commented Jan 2, 2017

That would be great. On Windows 7, with Jabref 3.7, everything looks good enough. But on Ubuntu 16.04, the Java file dialog is awful, very hard to navigate using keyboard and quite awkward.
There must be ways to link to the GTK file chooser somehow, perhaps this JavaFX thing will do that for us? http://java-gnome.sourceforge.net/doc/api/4.1/org/gnome/gtk/FileChooser.html

@tobiasdiez
Copy link
Member

@jdpipe the correct file dialog should be used with the JavaFX version. Could you please try out https://builds.jabref.org/javafx/ and report if everything is working as expected? Thanks!

@jdpipe
Copy link

jdpipe commented Mar 13, 2017

Hi Tobias

I tested the 'javafx' build (JabRef-4.0.0-dev--snapshot--2017-03-12--master--f0d79f876.jar) and it worked well. However, I did have to install some openfx packages on my machine first. Without those packages, there is just a cryptic message "Error: Could not find or load main class org.jabref.JabRefMain".

This raises a question -- with JabRef .jar package now topping 50MB, is there any prospect of some kind of lighter .jar that makes more use of the packages available on our machines? On Ubuntu, somebody from time to time re-packages Jabref into a much smaller 4 MB package (nice) but it obviously must be difficult, since it hasn't been updated beyond JabRef version 2.10.

Cheers
JP

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Mar 13, 2017

Hi JP,

thanks for testing. As we are switching to the new gui technology JavaFX, it requires the openjfx package.
Since a while the JabRef Version 3.8.2 succesfully is integrated into debian experimental and of course we hope to integrate the 4.0.0 version there one time, too.
https://packages.debian.org/experimental/jabref

At the moment the 4.0.0 is still under development, so we only provide the fat-jar files, which are automatically built from the CI server

Regards
Christoph

@koppor
Copy link
Member

koppor commented Mar 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants