Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JabRef 3.3 file links containing blanks are broken if non-default viewer is set #1381

Closed
gh-mike opened this issue May 11, 2016 · 4 comments
Closed
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: windows

Comments

@gh-mike
Copy link

gh-mike commented May 11, 2016

JabRef version 3.3 on Windows 10. After upgrading from version 3.1 all the file links containing blanks are broken when using Sumatra PDF. When trying to open a pdf file containing blanks, the pdf reader consider each piece of the file name as an independent file (each piece meaning each non-blank piece). This worked fine in 3.1. Tried to place quotes around the file name without success.

Steps to reproduce:

  1. Install Sumatra PDF
  2. Configure Sumatra PDF as the pdf reader (Options -> External programs -> Manage external file type -> edit pdf and set up Summatra PDF). Alternatively you can set up Sumatra as the defaul pdf reader in your system
  3. Link a pdf file containing blanks in the name (for example "my example pdf file.pdf") under the entry editor -> General -> File -> +
  4. Try to open the file and Summatra PDF will try to open four files (my, example, pdf, and file.pdf).

Ideally can configure Jabref to place quotes around the file name, when invoking the external reader.

@matthiasgeiger matthiasgeiger added the bug Confirmed bugs or reports that are very likely to be bugs label May 11, 2016
@matthiasgeiger
Copy link
Member

Thanks for your report!

Confirmed if a PDF viewer is set manually in the "Manage external file type" dialog (not only sumatra but also other PDF viewers).

System default works with whitespace in the file names.

@matthiasgeiger matthiasgeiger changed the title JabRef 3.3 file links containing blanks are broken with Sumatra PDF JabRef 3.3 file links containing blanks are broken if non-default viewer is set May 11, 2016
@Siedlerchr
Copy link
Member

Seems to be a problem with the settings than, because I worked on a fix for this in the opening methods.
Will look into that.

@stefan-kolb
Copy link
Member

Thank you for your report 👍
This should be fixed in blank-file-links. Please try the latest build from http://builds.jabref.org/blank-file-links.

@matthiasgeiger
Copy link
Member

👍 works for me.

tschechlovdev pushed a commit to tschechlovdev/jabref that referenced this issue May 21, 2016
…t viewer is set

* Fix JabRef#1381 File links containing blanks are broken if non-default viewer is set
* Consistently use ProcessBuilder instead of Runtime.exec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: windows
Projects
None yet
Development

No branches or pull requests

4 participants