Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative file links do not work anymore - Preferences are not saved #1313

Closed
2bein opened this issue Apr 28, 2016 · 4 comments
Closed

Relative file links do not work anymore - Preferences are not saved #1313

2bein opened this issue Apr 28, 2016 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@2bein
Copy link

2bein commented Apr 28, 2016

JabRef version 3.3 on Windows 7 64 bit

Just updated from 3.2 to 3.3, but existing external file links (relative to bib-file) are not working anymore. Found out that in Preferences... File.. "Allow file links relative...." was not ticked anymore. But changing the tick box has no effect!? And when restarting Jabref, the tickbox is deactivated, so preferences are actually NOT SAVED!

Can anyone reproduce?

Additional comment:
Ok, there is obviously a conflict with the Database properties - a special path was given here as a general file directory to override the preferences. It was set as a relative path, but only absolute path is obviously possible here, nevertheless what the preferences tick box say.

However: Still without the path set in database properties, the tick box "Allow file links relative...." does not work anymore and is not saved with the preferences!

@matthiasgeiger
Copy link
Member

Yes. This option seems not be saved correctly.

However, relative links are working for me (even without this option).

Please post an example BibTeX entry with further information where the bib-file and the referenced file is located.
Are there any messages in the different tabs of the Error Console (Help -> Show error console)?

@matthiasgeiger matthiasgeiger added bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Apr 28, 2016
@2bein
Copy link
Author

2bein commented May 6, 2016

Sorry for the delay...
Relative links are working, I agree. Errors console shows no erros. So I think we agree there is a bug with option saving and hope this will be solved in next version.
(Another bug is more serious for us - I will add a new ticket: Sorting of entries is always after YEAR, despite setting in database properties is "save entries in their original order")

@simonharrer
Copy link
Contributor

Since 3.3: "Removed configuration option to use database file directory as base directory for attached files and make it default instead"

It was just not removed from the UI, but the logic underneath was optimized and simplified. I will remove the UI option so this will not confuse users further.

simonharrer added a commit that referenced this issue May 9, 2016
This reverts commit 9442498.
@simonharrer simonharrer reopened this May 9, 2016
@simonharrer
Copy link
Contributor

Okay, the facts:

  • There are two check boxes at Options - Preferences - File: "Allow file links relative to the bib-files location" (A) and "Use the bib file location as the primary file directory" (B)
  • The option A has been removed from the preferences in 8825dd7, hence, it cannot be saved anymore, but the check box is still there
  • Checkbox B is only activated by checking Checkbox A
  • Checkbox B is saved in the pereferences and used in the code

At the moment, the code always allows relative links to the bib files location. Hence, the checkbox A can be removed from the UI, and checkbox B should always be enabled (usable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

3 participants