Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jstyle files - improper handling of quotation marks #1245

Closed
teertinker opened this issue Apr 19, 2016 · 2 comments · Fixed by #1246
Closed

Jstyle files - improper handling of quotation marks #1245

teertinker opened this issue Apr 19, 2016 · 2 comments · Fixed by #1246
Assignees
Labels
component: libre-office [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@teertinker
Copy link
Contributor

JabRef version 3.3 on Windows 10

Steps to reproduce:

  1. .Use the Citation file below/ rename to .jstyle
    test.txt
  2. Have a look at:
    BracketBefore=""
    BracketAfter=""

They are defined with quoutation marks according to the example at: http://jabref.sourceforge.net/OOPlugin-jabref.php

  1. create an empty LO document and cite some entries
  2. The following happens: ""DOE 1998""...

Expected was an entry without "brackets" before and after: DOE 1998
I know, the expected behavior can be triggered by the following code:
BracketBefore=
BracketAfter=

but for other cases quotation marks are needed, leaving me with inconsistent property definitions

@oscargus oscargus added component: libre-office [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs labels Apr 19, 2016
oscargus added a commit that referenced this issue Apr 19, 2016
@oscargus oscargus self-assigned this Apr 19, 2016
oscargus added a commit that referenced this issue Apr 19, 2016
@oscargus oscargus mentioned this issue Apr 19, 2016
@oscargus
Copy link
Contributor

oscargus commented Apr 19, 2016

You should be able to try out a fixed version at http://builds.jabref.org/fix1245 . I haven't tried it myself (no OO on the computer I'm sitting at), but the fix was quite straightforward so it should be OK...

@teertinker
Copy link
Contributor Author

Great! It works.

oscargus added a commit to oscargus/jabref that referenced this issue Apr 22, 2016
oscargus added a commit that referenced this issue Apr 22, 2016
Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue Apr 26, 2016
Filter filter for jstyle files
Extended BrowseAction to display file filter
Fixed NPE when selecting invalid jstyle (prevented style dialog from opening)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: libre-office [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants