Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Viewer: PDF shows only in half of the window size #10934

Closed
2 tasks done
Siedlerchr opened this issue Feb 27, 2024 · 3 comments · Fixed by #10961
Closed
2 tasks done

Document Viewer: PDF shows only in half of the window size #10934

Siedlerchr opened this issue Feb 27, 2024 · 3 comments · Fixed by #10961
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@Siedlerchr
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

mac as well

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Attach a pdf to an entry
  2. Go to View -> Open document viewer
  3. Maximize the view and see that the document content is not resized properly and there is free space at the bottom

=> The document should take up all space when resized

documentViewer

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr added ui bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 27, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 27, 2024
@cardionaut
Copy link
Contributor

Hi @Siedlerchr
This would be my first ever contribution and I am a bit of a Java noob still.
I would love to give this issue a shot if it isn't too urgent.
I work full-time and it might take me some time to get a hang of everything.
Let me know what you think, thanks!

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Feb 29, 2024
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Feb 29, 2024
@ThiloteE
Copy link
Member

ThiloteE commented Feb 29, 2024

Sure, thank you @cardionaut
This is an issue that might potentially be relevant to one of our Google Summer of Code (GSoC) projects, as there was a particular proposal, so it would be nice having it fixed or at least having somebody play a little with the UI settings in this part of the code, which would serve as a demonstration for what is possible.

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Feb 29, 2024
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

github-merge-queue bot pushed a commit that referenced this issue Mar 2, 2024
… (#10961)

* Fix "Document Viewer: PDF shows only in half of the window size" #10934

* move changelog to unreleased
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants