Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't escape full screen + menus stay closed (after upgrade to 5.12/5.13) #10731

Open
2 tasks done
sparusaurata opened this issue Dec 27, 2023 · 177 comments · May be fixed by #11991
Open
2 tasks done

Can't escape full screen + menus stay closed (after upgrade to 5.12/5.13) #10731

sparusaurata opened this issue Dec 27, 2023 · 177 comments · May be fixed by #11991
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: linux ui

Comments

@sparusaurata
Copy link

sparusaurata commented Dec 27, 2023

JabRef version

5.12 (latest release)

Operating system

GNU / Linux

Details on version and operating system

Mint 21.2 with Cinnamon 5.8.4

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Upgrade to 5.12 by manually installing the Debian package.
  2. Open JabRef.
  3. The window is in full-screen (Cinnamon's title bar and bottom panel aren't visible), and when I click on a menu item (File, Edit, etc.) it appears and disappears immediately after.
  4. The solutions from https://docs.jabref.org/installation (adding Java options) don't change anything.

Appendix

Notice that I'll be able to perform some tests tomorrow if needed, but then I'll just re-install a previous version to be able to work. 😞

Log File
2023-12-27 18:44:25 [JavaFX-Launcher] sun.util.logging.internal.LoggingProviderImpl$JULWrapper.log()
WARN: Unsupported JavaFX configuration: classes were loaded from 'module org.jabref.merged.module', isAutomatic: false, isOpen: true
2023-12-27 18:44:27 [JavaFX Application Thread] org.jabref.gui.StateManager.setActiveDatabase()
INFO: No open database detected
2023-12-27 18:44:27 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Not updating theme because it hasn't changed
2023-12-27 18:44:27 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Theme set to Theme{type=EMBEDDED, name='Dark.css'} with base css StyleSheet{jrt:/org.jabref/org/jabref/gui/Base.css}
2023-12-27 18:44:27 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Not updating theme because it hasn't changed
2023-12-27 18:44:27 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Theme set to Theme{type=EMBEDDED, name='Dark.css'} with base css StyleSheet{jrt:/org.jabref/org/jabref/gui/Base.css}
2023-12-27 18:44:29 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getFetcherKeysFromKeyring()
WARN: JabRef could not open the key store
2023-12-27 18:44:29 [pool-1-thread-1] org.jabref.gui.JabRefDialogService.notify()
INFO: Ouverture en cours: (...)
@Siedlerchr
Copy link
Member

@ThiloteE don't you have Linux mint as well?

@ThiloteE
Copy link
Member

ThiloteE commented Dec 27, 2023

I am on an older version of Linux Mint (20.3). I use the flatpak version of JabRef. The newest portable version I can run there is JabRef 5.9, because JabRef requires a newer kernel, which by default is only delivered with Ubuntu 22.0X or something and Linux Mint 20.3 is based on an older Ubuntu. I have not tried any of the deb versions.

@Siedlerchr
Copy link
Member

Can you test the latest 5.13 from here?
https://builds.jabref.org/main/
We donwgraded javafx

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

I can't reproduce in Ubuntu 22.04, but I don't use Cinnamon

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Can't replicate it in Ubuntu 22.04 using Cinnamon, but I am unable to open JabRef in full-screen, so perhaps not that useful.

This might be related to the original part of #4939 ?

@sparusaurata
Copy link
Author

sparusaurata commented Dec 28, 2023

Can you test the latest 5.13 from here? https://builds.jabref.org/main/ We donwgraded javafx

The bug persists. 😢

  • I downgraded to 5.6 (a bit randomly, since I didn't remember the previous version I had) and it works fine.
  • EDIT: I also tried 5.10, it bugs.

@Siedlerchr
Copy link
Member

Then this sounds more like a bug in cinnamonn

@AdamWysokinski
Copy link
Contributor

AdamWysokinski commented Jan 2, 2024

I have a similar issue using Linux/i3 wm. Menus close immediately, unless the mouse key is kept pressed. But then, menu options cannot be selected. Menus keyboard shortcuts works fine. Same for 5.13. The issue is not present in 5.11.

@messiem
Copy link

messiem commented Jan 2, 2024

Same issue here; I just installed 5.12 and did not have the issue in 5.11.
Running Ubuntu 22.04.3 in Wayland.

Updating this because I first thought it had to do with Wayland but maybe not; my other (Xorg?) Ubuntu version was set up differently for displays. From what I can tell it had more to do with using dual displays and which one was set up as primary (the bug only happened when my external display was set up as primary). I installed 5.13 following a link given above and while the bug was still there at first, after a bit more random tests I am back on Wayland + primary external display and all looks well now (no idea why), so I won't touch this anymore - I'll report back if the bug comes back.

@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label Jan 2, 2024
Siedlerchr added a commit that referenced this issue Jan 20, 2024
Fixes #5867
Probably also #10731
@Siedlerchr
Copy link
Member

Can you please test this version? https://builds.jabref.org/pull/10808/merge
@AdamWysokinski At least the menu problem on i3 should be fixed

@AdamWysokinski
Copy link
Contributor

The new build works fine on i3, thanks!

calixtus pushed a commit that referenced this issue Jan 21, 2024
@Ectras
Copy link

Ectras commented Jan 25, 2024

I have the same issue on Ubuntu 22.04.3 with Wayland. The window is in full screen and the menus disappear. I can confirm that installing 5.13 from https://builds.jabref.org/pull/10808/merge solved the issues with the menus for me (they are working normally again), but the window is still in full screen.

@AdamWysokinski
Copy link
Contributor

With the build 10808 on i3 there is no problem with switching full-screen on and off.

@mButlerDM
Copy link

I have this problem as well on the latest 5.13 build as of this comment. I can interact with menus by clicking now but the application is still stuck in full screen.

Linux Mint 21.2 with Cinnamon 5.8.4.

@teertinker
Copy link
Contributor

teertinker commented Mar 7, 2024

I updated to 5.12 today and have a similar issue on Ubuntu 22.04.. In Fullscreen Main Menu is not working. However in window mode, everything works as expected.
Bildschirmaufzeichnung vom 07.03.2024, 14:31:26.webm

Update: 5.13 dev solved the issue for me.

@karls0
Copy link

karls0 commented Mar 11, 2024

Hi,
I have the same problem: 5.13 from https://builds.jabref.org/pull/10808/merge solved the issues with the menus for me (they are working normally again), but the window is still in full screen. I can use the program now, but I can't change workspaces because of fullscreen mode.
How can I switch to window mode?
I'm using Mint 21.3 Virginia.

@plyaden
Copy link

plyaden commented Mar 13, 2024

Hi, I have the same problem: 5.13 from https://builds.jabref.org/pull/10808/merge solved the issues with the menus for me (they are working normally again), but the window is still in full screen. I can use the program now, but I can't change workspaces because of fullscreen mode. How can I switch to window mode? I'm using Mint 21.3 Virginia.

Hi, i have the same Problem on Obuntu 22.04. Sometimes it works to click the windowsbutton + arrowkeys, or just restart RabRef. The Problem only occurs at the first Start of the Software for me.

@Siedlerchr
Copy link
Member

Can you try the version with javafx22-ea-28from here? https://builds.jabref.org/jdk-ea/

@karls0
Copy link

karls0 commented Mar 13, 2024

Hi Chris,
I tried the version you mentioned, but it is worse than 5.13.233. No window decoration and the menus don't stay open to select an item. Good to remember Alt+F4 to quit :-) I also found out how to switch workspaces by using Ctrl+Alt-up-arrow. So not a big Problem for me, but thank you for the suggestion.

@karls0
Copy link

karls0 commented Mar 13, 2024

@plyaden
Thank you, but neither method works for me.

@calixtus
Copy link
Member

calixtus commented Mar 13, 2024

Tried just now the latest build in linux-portable with my linux machine, arch linux, kde, wayland, but could not reproduce...
grafik

@koppor
Copy link
Member

koppor commented Mar 14, 2024

@calixtus It seems to be about Linux Mint and Cinnamon. - Can you start Cinnamon on arch maybe?

@wujastyk
Copy link

JabRef 5.13--2024-03-20--047a975
Linux 6.5.0-26-generic amd64
Java 21.0.2
JavaFX 22+30

I'm having this same problem (Jabref in fullscreen mode and can't get out of it; clicking menus doesn't open the dropdown). I'm using Linux Mint and Cinnamon. Other programs running at the same time are normal; it's just Jabref.

@wujastyk
Copy link

Can you try the version with javafx22-ea-28from here? https://builds.jabref.org/jdk-ea/

I tried this - no improvement.

@wujastyk
Copy link

wujastyk commented Mar 21, 2024

JabRef 5.13--2024-03-20--82a0338
Linux 6.5.0-26-generic amd64
Java 21.0.2
JavaFX 22+30

The fullscreen-only problem appears only on my laptop (Thinkpad T580) and not on my dual-screen desktop setup. There, the same version of JabRef behaves just fine.

I don't know if it's related, but once again JabRef presents the "custom entry types" approval screen on every startup.

image

@koppor
Copy link
Member

koppor commented Aug 22, 2024

@TLCFEM Thank you for the input. I could replicate. Need to leave now. Let's see when I can come ack to this. - Maybe, there is someone else with some Java skills. The first thing to try would be if ti also happens with our JavaFX reproducer https://github.com/Siedlerchr/javafxreproducer.

#11664 - and vagrant up fires up the VM.

@TLCFEM
Copy link

TLCFEM commented Aug 22, 2024

I tried gnome versions 44, 45 and 46, cannot reproduce this behavior.
So it seems only 43.9 can trigger this.

@stertooy
Copy link

stertooy commented Sep 2, 2024

Had this problem on Linux Mint 21.3 and 22 (Cinnamon), dual monitor setup.

After reading this discussion, I installed jabref_5.16_amd64-jdk22-javafx23.deb. The problem appears to be fixed in that version.

@LoayGhreeb
Copy link
Collaborator

I'm using ShareX on Windwos 11, and with its "Borderless window" tool, I can partially reproduce the issue. The menu bar works, but the close, maximize, and minimize buttons are hidden.

image

To reproduce:

  • Open ShareX and select "Borderless window" from the "Tools" menu.
  • Choose the JabRef window and make it borderless.

Tested with JFX versions 22.0.2, 23-ea+27, and 24-ea+5, all showing the same behavior. I also tested the javafxreproducer and had the same behavior.

The borderless tool worked on multiple other applications without hiding the buttons.

@nsheff
Copy link

nsheff commented Sep 16, 2024

I am also experiencing these issues, with forced full-screen mode and no title bar or way to change/minimize the windows, and menus being the wrong places. I am using:

JabRef 5.15--2024-07-10--1eb3493
Linux 6.8.0-44-generic amd64
Java 21.0.2
JavaFX 22.0.1+7

on Ubuntu 24.04, installed from the .deb


To test, I installed the development version, (5.16.361), and the problem changed; now I can resize the window (the minimize, maximize, and close buttons are back), but the menus are still showing up in the wrong place, even outside the window:

image

Also, not sure if it's related, but I cannot resize the window from the corners anymore. This is on a basically fresh install of ubuntu 24.04.

@wujastyk
Copy link

wujastyk commented Sep 16, 2024

JabRef 5.16--2024-09-14--67ca174
Linux 6.8.0-44-generic amd64
Java 21.0.2
JavaFX 22.0.2+4

This was squashed a while back, but unfortunately it's back on my system too. Single screen, Thinkpad laptop.

Added note: my two-screen, desktop machine (same Linux version) does not exhibit the issue.

@Siedlerchr
Copy link
Member

Can you all try the latest dev version? We upgraded to javafx 23 #11757

@wujastyk
Copy link

wujastyk commented Sep 18, 2024

JabRef 5.16--2024-09-17--ed0e90e
Linux 6.8.0-44-generic amd64
Java 21.0.2
JavaFX 23+29

Today's main dev build still gave me the fullscreen problem on my laptop.

And today:
JabRef 5.16--2024-09-20--8a25938
Linux 6.8.0-45-generic amd64
Java 21.0.2
JavaFX 23+29

@stertooy
Copy link

Can you all try the latest dev version? We upgraded to javafx 23 #11757

On my two-monitor desktop, this version doesn't exhibit the issue anymore.

JabRef 5.16--2024-09-19--4e864f6
Linux 6.8.0-45-generic amd64 
Java 21.0.2 
JavaFX 23+29

@wujastyk
Copy link

JabRef 5.16--2024-09-20--5ac788c
Linux 6.8.0-45-generic amd64
Java 21.0.2
JavaFX 23+29

  • Thinkpad T580: fullscreen/menu problem.
    Solved by loading with CLI /opt/jabref/bin/JabRef -p ~/newjabref.prefs.xml.txt (prefs attached)

  • 2-screen desktop system, same software, no problem, no need for the -p trick.

newjabref.prefs.xml.txt

@busFred
Copy link

busFred commented Sep 28, 2024

JabRef 5.16--2024-09-20--5ac788c Linux 6.8.0-45-generic amd64 Java 21.0.2 JavaFX 23+29

* Thinkpad T580:  fullscreen/menu problem.
  Solved by loading with CLI `/opt/jabref/bin/JabRef -p ~/newjabref.prefs.xml.txt`  (prefs attached)

* 2-screen desktop system, same software, no problem, no need for the -p trick.

newjabref.prefs.xml.txt

this solves my problem on thinkpad t480s linux mint! thanks @wujastyk

@busFred
Copy link

busFred commented Oct 9, 2024

JabRef 5.16--2024-09-20--5ac788c Linux 6.8.0-45-generic amd64 Java 21.0.2 JavaFX 23+29

* Thinkpad T580:  fullscreen/menu problem.
  Solved by loading with CLI `/opt/jabref/bin/JabRef -p ~/newjabref.prefs.xml.txt`  (prefs attached)

* 2-screen desktop system, same software, no problem, no need for the -p trick.

newjabref.prefs.xml.txt

@wujastyk do you have to run /opt/jabref/bin/JabRef -p ~/newjabref.prefs.xml.txt every time you restart your computer?

@wujastyk
Copy link

wujastyk commented Oct 9, 2024

Every time I run JabRef. I have that command in my launcher icon.

@koppor
Copy link
Member

koppor commented Oct 13, 2024

Every time I run JabRef. I have that command in my launcher icon.

Reading #11530 (comment) - do you need this script? - I wonder if this issue is the same than the other issue.

@wujastyk
Copy link

No, today's tests were just by launching /opt/jabref/bin/JabRef without arguments.

The program launches and behaves just fine. But there are warnings at the CLI. Here's a video, so you can see them.

jabref-2024-10-13_10.23.45.mp4

@koppor
Copy link
Member

koppor commented Oct 14, 2024

(JabRef:296730): Gdk-WARNING: XSetErrorHandler() called with a GDK error trap pushed. Don't do that.

@calixtus
Copy link
Member

Gdk warning is a well known javafx issue: https://bugs.openjdk.org/browse/JDK-8156779

@stertooy
Copy link

After migrating to a new OS (Ubuntu 24.10 Cinnamon), I encountered this bug again, even with recent javafx23 and javafx24 builds. In particular, I tried the following builds:

  • Latest snap version
  • Latest flathub version
  • jabref_5.16_amd64-jdk22-javafx23.deb
  • jabref_5.16_amd64-jdk22-javafx24.deb
  • jabref_6.0_amd64.deb
  • jabref_6.0_amd64-jdk22-javafx24.deb

All of these exhibit the same behaviour.

On first install, Jabref opens fullscreen (not just maximised), and menus are unusuable: they stay open as long as I hold LMB, but that's all they do. Hovering over any of the options/submenus does nothing, not even the background change to indicate I'm hovering. If the process is killed and restarted, it again opens in fullscreen.

However, when using the shortcut key combination in Cinnamon for "Toggle fullscreen state", Jabref becomes windowed and then the menus are usuable again. After having toggled the fullscreen state at least once, Jabref starts up in windowed mode from then on, because of loading with a preferences file. However, if I toggle back to fullscreen, menus are once again broken.

So, I'm guessing my earlier report saying this was fixed was wrong, and I was just using a preferences file without realising it. And I guess this problem is actually two separate problems: Jabref starting fullscreen by default (unless this is intentional?), and menus being broken while fullscreen.

@calixtus
Copy link
Member

This makes me wonder if the default setting for full screen in Cinnamon is interpreted as fullscreen. Maybe forcing no-fullscreen as default helps. I will try to make a test pr so you can check if this fixes the issue.

@calixtus calixtus linked a pull request Oct 16, 2024 that will close this issue
7 tasks
@calixtus
Copy link
Member

The build for #11991 should be available in a few minutes and announced in the PR discussion thread. Would be so kind to test it then?

@wujastyk
Copy link

6.0--2024-10-15--0e08b24
Linux 6.8.0-47-generic amd64
Java 21.0.2
JavaFX 23+29

@stertooy's comments prompted me to fool around a bit with Cinnamon's fullscreen and maximize settings. Cinnamon's Keyboard/shortcuts menu allow one to attach these settings to keys. I hadn't realized there was a system-level "fullscreen" setting. And "fullscreen" is different from "maximize". Maximize is not an issue.

I'm launching JR on a Thinkpad laptop, T580. I'm using /opt/jabref/bin/JabRef with no arguments. Everything's fine: I get a compliant, windowed session that I can maximize or minimize without issue.

But if I go fullscreen, using a system keystroke, then I'm in trouble. The menus start to misbehave in the way we've seen before. If I use the system toggle to leave fullscreen, all is well again. If I quit JabRef from a fullscreen session and then restart it, it starts normally, not in fullscreen (so it's not "remembering").

All that this proves is that fullscreen and menu-misbehaviour are connected.

@koppor
Copy link
Member

koppor commented Oct 16, 2024

it starts normally, not in fullscreen (so it's not "remembering").

We removed that some months ago 👼. - I think, we removed it because of this issue...

@wujastyk
Copy link

JabRef 6.0-PullRequest11991.6424--2024-10-16--d9ac330
Linux 6.8.0-47-generic amd64
Java 21.0.2
JavaFX 23+29

I've just installed the build from #11991. I see no difference in behaviour. But I wouldn't expect it, since I'm not having the "fullscreen" problem any longer, as you say @koppor.

Toggling Cinnamon's fullscreen deliberately, yes, I see the menu problem, as described above.

@stertooy
Copy link

The build for #11991 should be available in a few minutes and announced in the PR discussion thread. Would be so kind to test it then?

Just tried this build, but I don't think anything changed, unfortunately.

JabRef 6.0-PullRequest11991.6424--2024-10-16--d9ac330
Linux 6.11.0-8-generic amd64 
Java 21.0.2 
JavaFX 23+29

I did notice some weird behaviour, which also happens in the previously mentioned versions. Suppose I start up Jabref without preferences saved in my home folder. Then Jabref starts in fullscreen. Subsequently:

  • If Jabref is closed while in fullscreen (e.g. through ALT+F4), it will start in fullscreen on the next startup.
  • If Jabref is taken out of fullscreen, it becomes windowed and maximised. If I close it while windowed+maximised, it will start in fullscreen on the next startup, and not windowed+maximised.
  • If Jabref is taken out of fullscreen and then unmaximised, it will open windowed+unmaximised on the next startup.

If I have unmaximised Jabref at least once on a previous startup, it still shows some odd behaviour on subsequent startups, probably due to my double monitor setup:

  • If Jabref was windowed and unmaximised, it will startup on the same monitor and with the same window size it was closed.
  • If Jabref was either windowed+maximised or fullscreen when it was closed, it will startup windowed+maximised, but always on the same monitor, not necessarily the monitor it was on bwhen it was closed. In my case, this is the monitor labeled as "1" in my Display settings (which is not set as the primary monitor).

@Liam-Twomey
Copy link

To follow up, I was having no issues on this after the August 2 build of #11440, but the issue re-emerged last week (I did not update JabRef in the meantime, so I really do not know what caused it). Installing the build of #11991 did not fix it. I'm unsure what's going on, and why after two months of it working fine it suddenly reverted to the broken "false fullscreen" mode. I wouldn't expect that Mint updated a JabRef dependency in the background, but that's all I can think of.

@koppor
Copy link
Member

koppor commented Nov 25, 2024

I'm unsure what's going on, and why after two months of it working fine it suddenly reverted to the broken "false fullscreen" mode. I wouldn't expect that Mint updated a JabRef dependency in the background, but that's all I can think of.

Yeah - Wayland surely got updates the last two months...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs os: linux ui
Projects
Status: High priority
Development

Successfully merging a pull request may close this issue.