Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort languages alphabetically in the preferences #10660

Closed
Siedlerchr opened this issue Nov 21, 2023 · 5 comments · Fixed by #10675
Closed

Sort languages alphabetically in the preferences #10660

Siedlerchr opened this issue Nov 21, 2023 · 5 comments · Fixed by #10675
Assignees
Labels
component: preferences FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: enhancement

Comments

@Siedlerchr
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
In the preferences, one can change the language of the UI. The list seems to be sorted arbitrarily.

Describe the solution you'd like
It should be sorted alphabetically.

Additional context
Add any other context or screenshots about the feature request here.
283370906-3bcf6027-4646-47f5-9604-95474d5bf33d

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Nov 21, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Nov 21, 2023
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Nov 21, 2023
@JannCamilo
Copy link

Hello, we are a group of university students and we are interested in this contribution, could you assigned it to us ?

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Nov 22, 2023
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@HarikaB11
Copy link

Hi @Siedlerchr, I would like to work on this issue. Please consider my request as I am working on it as a part of College project.

@ThiloteE
Copy link
Member

@HarikaB11
Please choose another issue.

Why choose another issue?

In general we assign issues to students on first come, first serve basis. We have issues that are reserved (you can see it in the top right corner at the projects section), as grading requirements may differ and group work may not be permitted by some lecturers and in some courses.

Keep also in mind that double work must not be, but can be inefficient.

  • In principle, all issues are free to take, so if you are fast you could theoretically come up with your own solution first and propose a change, but since somebody already asked to be assigned to this issue and may already have started working on a fix, it could create a little bit of disappointment and double work for the both of you. Ultimately only one of your pull-requests will be merged, so if your study course requires you to demonstrage a successfully merged commit this is a risky plan.
  • Supervising two different pull-requests creates more work for maintainers, since they have to hop between pull-requests to compare them and communicate with the both of you.

Why not choose another issue?

In principle, you could work together on this issue (groupwork), but this would require good communication skills on your part. If both of you are willing, you should exchange contact details (e.g. via gitter/e-mail etc.).

@newma2n
Copy link
Contributor

newma2n commented Nov 28, 2023

Hello, I am part of Jann Sanchez's team.Mechanically speaking, we can say the issue is resolved , but it works for languages except for those that are non-Latin (Arabic, etc.). How can we manage this case? Because we sorted them according to "displayename."

github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2023
* classic sort, only for latin alphabet

* sort all languages alphabetically

* sort all languages alphabetically without normalized

* Check style modification

* Update CHANGELOG.md

* classic sort, only for latin alphabet

* sort all languages alphabetically

* sort all languages alphabetically without normalized

* Check style modification

* Update CHANGELOG.md

* Update CHANGELOG.md

* use list

* delete comment

* use pattern

* fix

* pattern var

* remove duplicated sorted

---------

Co-authored-by: Théo Granier <[email protected]>
Co-authored-by: j23sanch <[email protected]>
Co-authored-by: Siedlerchr <[email protected]>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Dec 10, 2023
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: preferences FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: enhancement
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants