Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import by id: make button larger #10507

Closed
2 tasks done
tobiasdiez opened this issue Oct 16, 2023 · 8 comments · Fixed by #10588
Closed
2 tasks done

Import by id: make button larger #10507

tobiasdiez opened this issue Oct 16, 2023 · 8 comments · Fixed by #10588
Assignees
@JMS063
Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow ui

Comments

@tobiasdiez
Copy link
Member

JabRef version

5.10 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Search something by id. Once you click on "Generate" the button text switches to "Searchi...". It would be better if the button would be slightly larger from the get-go to show the complete text.
image

Appendix

...

Log File 
Paste an excerpt of your log file here
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs ui labels Oct 16, 2023
@JMS063
Copy link
Contributor

JMS063 commented Oct 17, 2023

Hi there, I would like work oaths issue, please assign it to me if possible!

@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 17, 2023
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 17, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 17, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@JMS063
Copy link
Contributor

JMS063 commented Oct 20, 2023

Hi there,
I have updated the size of the button, have a look before I rise a PR :)

Screenshot 2023-10-20 at 12 25 14
Screenshot 2023-10-20 at 12 25 19

@DiamondMyK
Copy link
Contributor

Hi, I'm new to open source and want to try to solve some simple problems. Can you assign this issue to me? I would appreciate it!

@JMS063
Copy link
Contributor

JMS063 commented Oct 21, 2023

I have already solve this issue :)

@ThiloteE
Copy link
Member

ThiloteE commented Oct 21, 2023 •
edited
Loading

@DiamondMyK , please have a look at our good first issues projects page. We usually only assign one student (or one group of students that know each other) per issue, as we don't know your grading requirements.
At the top right of an issue, you will see if that issue is already reserved and assigned to somebody.

image

@koppor
Copy link
Member

koppor commented Oct 24, 2023

I have already solve this issue :)

I can't see anything athttps://github.com/JMS063/jabref/branches. Where do you share your progess? Looking forward!

@JMS063
Copy link
Contributor

JMS063 commented Oct 24, 2023

I haven't managed to make a push. I will push tomorrow and make a pull request as soon as possible

@JMS063 JMS063 mentioned this issue Oct 26, 2023
Merged
6 tasks
JMS063 pushed a commit to JMS063/jabref that referenced this issue Oct 29, 2023
@JMS-crypto
fix issue JabRef#10507
bb51bae
github-merge-queue bot pushed a commit that referenced this issue Nov 2, 2023
@JMS063 @koppor
@JMS-crypto @calixtus
Make generate button wider (#10588)
ec81fc6 
* fix issue#10507

changed the size of the button

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* fix issue #10507

* Generified changelog entry for small visual fixes

* Update Base.css

---------

Co-authored-by: Oliver Kopp <[email protected]>
Co-authored-by: Minghao <[email protected]>
Co-authored-by: Carl Christian Snethlage <[email protected]>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Prioritization Nov 2, 2023
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JMS063 JMS063

Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow ui
Projects
Good First Issues
Archived in project
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make generate button wider JMS063/jabref
5 participants
@koppor @tobiasdiez @ThiloteE @JMS063 @DiamondMyK