Skip to content

Commit

Permalink
Fixed #636 by using DOICheck and DOIStrip in export filters (#1624)
Browse files Browse the repository at this point in the history
  • Loading branch information
oscargus authored and simonharrer committed Jul 25, 2016
1 parent f90d1d0 commit fc603b4
Show file tree
Hide file tree
Showing 19 changed files with 21 additions and 20 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
### Fixed
- Fixed [#1264](https://github.com/JabRef/jabref/issues/1264): S with caron does not render correctly
- LaTeX to Unicode converter now handles combining accents
- Fixed [#636](https://github.com/JabRef/jabref/issues/636): DOI in export filters
- Fixed [#1527](https://github.com/JabRef/jabref/issues/1527): 'Get BibTeX data from DOI' Removes Marking
- Fixed [#1592](https://github.com/JabRef/jabref/issues/1592): LibreOffice: wrong numbers in citation labels

Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/resource/layout/bibordf.article.layout
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<bibo:Article rdf:about="http://dx.doi.org/\format[XMLChars]{\doi}">
<bibo:Article rdf:about="\format[DOICheck,XMLChars]{\doi}">

\begin{title} <dc:title>\format[XMLChars]{\title}</dc:title>\end{title}
\begin{year} <dc:date>\year</dc:date>\end{year}
\begin{journal} <dcterms:isPartOf><bibo:Journal><dc:title>\format[XMLChars]{\journal}</dc:title></bibo:Journal></dcterms:isPartOf>\end{journal}
\begin{volume} <bibo:volume>\format[XMLChars]{\volume}</bibo:volume>\end{volume}
\begin{doi} <bibo:doi>\format[XMLChars]{\doi}</bibo:doi>\end{doi}
\begin{doi} <bibo:doi>\format[DOIStrip,XMLChars]{\doi}</bibo:doi>\end{doi}


\begin{author}
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/resource/layout/bibordf.layout
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<bibo:Document rdf:about="http://dx.doi.org/\doi">
<bibo:Document rdf:about="\format[DOICheck]{\doi}">

\begin{title} <dc:title>\format[XMLChars]{\title}</dc:title>\end{title}
\begin{year} <dc:date>\year</dc:date>\end{year}
\begin{doi} <bibo:doi>\format[XMLChars]{\doi}</bibo:doi>\end{doi}
\begin{doi} <bibo:doi>\format[DOIStrip,XMLChars]{\doi}</bibo:doi>\end{doi}

\begin{author}
\format[XMLChars,CreateBibORDFAuthors]{\author}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/bibtexml.layout
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
\begin{howpublished} <bibtex:howpublished>\format[XMLChars]{\howpublished}</bibtex:howpublished>\end{howpublished}
\begin{abstract} <bibtex:abstract>\format[XMLChars]{\abstract}</bibtex:abstract>\end{abstract}
\begin{url} <bibtex:url>\format[XMLChars]{\url}</bibtex:url>\end{url}
\begin{doi} <bibtex:doi>\format[XMLChars]{\doi}</bibtex:doi>\end{doi}
\begin{doi} <bibtex:doi>\format[DOIStrip,XMLChars]{\doi}</bibtex:doi>\end{doi}
\begin{eid} <bibtex:eid>\format[XMLChars]{\eid}</bibtex:eid>\end{eid}
\begin{type} <bibtex:type>\format[XMLChars]{\type}</bibtex:type>\end{type}
\begin{crossref} <bibtex:crossref>\format[XMLChars]{\crossref}</bibtex:crossref>\end{crossref}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/html.inbook.layout
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

\begin{doi}
<div class="bibtex_doi">
<a href="http://dx.doi.org/\doi">doi</a>
<a href="\format[DOICheck]{\doi}">doi</a>
</div>
\end{doi}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

\begin{doi}
<div class="bibtex_doi">
<a href="http://dx.doi.org/\doi">doi</a>
<a href="\format[DOICheck]{\doi}">doi</a>
</div>
\end{doi}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/html.layout
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

\begin{doi}
<div class="bibtex_doi">
<a href="http://dx.doi.org/\doi">doi</a>
<a href="\format[DOICheck]{\doi}">doi</a>
</div>
\end{doi}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/ris/ris.article.layout
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ TY - JOUR
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{issn}U1 - \format[FormatChars]{\issn}\end{issn}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/ris/ris.book.layout
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ TY - BOOK
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{issn}U1 - \format[FormatChars]{\issn}\end{issn}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ TY - CONF
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{issn}U1 - \format[FormatChars]{\issn}\end{issn}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ TY - CHAP
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{issn}U1 - \format[FormatChars]{\issn}\end{issn}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ TY - CONF
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{issn}U1 - \format[FormatChars]{\issn}\end{issn}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/ris/ris.layout
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ TY - GEN
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ TY - THES
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/ris/ris.patent.layout
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ TY - PAT
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ TY - THES
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ TY - RPRT
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ TY - UNPB
\begin{pages}SP - \format[FormatChars,FirstPage]{\pages}
EP - \format[FormatChars,LastPage]{\pages}\end{pages}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/resource/layout/ris/ris.www.layout
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ TY - ELEC
\begin{title}T1 - \format[FormatChars]{\title}\end{title}
\begin{year}Y1 - \format[FormatChars]{\year}\end{year}\begin{month}/\format[FormatChars,RisMonth]{\month}\end{month}
\begin{url}UR - \url\end{url}
\begin{doi}M3 - http://dx.doi.org/\doi\end{doi}
\begin{doi}M3 - \format[DOICheck]{\doi}\end{doi}
\begin{keywords}\format[FormatChars,RisKeywords]{\keywords}\end{keywords}
\begin{file}L1 - \format[FileLink(pdf)]{\file}\end{file}
\begin{comment}N1 - \format[FormatChars]{\comment}\end{comment}
Expand Down

0 comments on commit fc603b4

Please sign in to comment.