Skip to content

Commit

Permalink
Fix fetcher tests (#9466)
Browse files Browse the repository at this point in the history
* Fix semantic scholar

* fix medline test, pii is now pages?

* Remove Citeseer fetcher

Co-authored-by: Oliver Kopp <[email protected]>
  • Loading branch information
Siedlerchr and koppor authored Dec 17, 2022
1 parent 4eafeef commit eae2a90
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
### Removed

- We removed "last-search-date" from the SLR feature, because the last-search-date can be deducted from the git logs. [#9116](https://github.com/JabRef/jabref/pull/9116)


- We removed the [CiteseerX](https://docs.jabref.org/collect/import-using-online-bibliographic-database#citeseerx) fetcher, because the API used by JabRef is sundowned.



Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/importer/WebFetchers.java
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public static SortedSet<SearchBasedFetcher> getSearchBasedFetchers(ImportFormatP
set.add(new DBLPFetcher(importFormatPreferences));
set.add(new SpringerFetcher(importerPreferences));
set.add(new CrossRef());
set.add(new CiteSeer());
// set.add(new CiteSeer());
set.add(new DOAJFetcher(importFormatPreferences));
set.add(new IEEE(importFormatPreferences, importerPreferences));
set.add(new CompositeSearchBasedFetcher(set, 30));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

@Disabled
@FetcherTest
class CiteSeerTest {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void setUp() throws InterruptedException {
.withField(StandardField.AUTHOR, "Endharti, Agustina Tri and Wulandari, Adisti and Listyana, Anik and Norahmawati, Eviana and Permana, Sofy")
.withField(new UnknownField("country"), "England")
.withField(StandardField.DOI, "10.1186/s12906-016-1345-0")
.withField(new UnknownField("pii"), "10.1186/s12906-016-1345-0")
.withField(new UnknownField("pii"), "374")
.withField(new UnknownField("pmc"), "PMC5037598")
.withField(StandardField.ISSN, "1472-6882")
.withField(new UnknownField("issn-linking"), "1472-6882")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class SemanticScholarTest implements PagedSearchFetcherTest {
.withField(StandardField.DOI, "10.1145/2884781.2884806")
.withField(StandardField.TITLE, "Overcoming Open Source Project Entry Barriers with a Portal for Newcomers")
.withField(StandardField.URL, "https://www.semanticscholar.org/paper/4bea2b4029a895bf898701329409e5a784fc2090")
.withField(StandardField.VENUE, "2016 IEEE/ACM 38th International Conference on Software Engineering (ICSE)");
.withField(StandardField.VENUE, "International Conference on Software Engineering");

private SemanticScholar fetcher;
private BibEntry entry;
Expand Down Expand Up @@ -167,7 +167,7 @@ public void findByEntry() throws Exception {
.withField(StandardField.YEAR, "2018")
.withField(StandardField.DOI, "10.1007/978-3-030-02302-7_1")
.withField(StandardField.URL, "https://www.semanticscholar.org/paper/3bb026fd67db7d8e0e25de3189d6b7031b12783e")
.withField(StandardField.VENUE, "PoEM");
.withField(StandardField.VENUE, "The Practice of Enterprise Modeling");

entry.withField(StandardField.TITLE, "Formalising BPMN Service Interaction Patterns");
BibEntry actual = fetcher.performSearch(entry).get(0);
Expand Down

0 comments on commit eae2a90

Please sign in to comment.