Refactor enable/disable logic to its own method

JabRef · Nov 3, 2018 · 8dd0800 · 8dd0800
1 parent f13fb65
commit 8dd0800
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/org/jabref/gui/preferences/GeneralTab.java b/src/main/java/org/jabref/gui/preferences/GeneralTab.java
@@ -4,7 +4,6 @@
 import java.time.format.DateTimeFormatter;
 
 import javafx.collections.FXCollections;
-import javafx.event.ActionEvent;
 import javafx.scene.Node;
 import javafx.scene.control.Button;
 import javafx.scene.control.CheckBox;
@@ -63,7 +62,7 @@ public GeneralTab(DialogService dialogService, JabRefPreferences prefs) {
         if (!useTimeStamp.isSelected()) {
             updateTimeStamp.setDisable(true);
         }
-        useTimeStamp.setOnAction(e->updateTimeStamp.setDisable(!useTimeStamp.isSelected()));
+        useTimeStamp.setOnAction(e->setDisableUpdateTimeStamp());
         overwriteOwner = new CheckBox(Localization.lang("Overwrite"));
         overwriteTimeStamp = new CheckBox(Localization.lang("If a pasted or imported entry already has the field set, overwrite."));
         enforceLegalKeys = new CheckBox(Localization.lang("Enforce legal characters in BibTeX keys"));
@@ -134,12 +133,16 @@ public Node getBuilder() {
         return builder;
     }
 
+    private void setDisableUpdateTimeStamp() {
+        updateTimeStamp.setDisable(!useTimeStamp.isSelected());
+    }
+
     @Override
     public void setValues() {
         useOwner.setSelected(prefs.getBoolean(JabRefPreferences.USE_OWNER));
         overwriteOwner.setSelected(prefs.getBoolean(JabRefPreferences.OVERWRITE_OWNER));
         useTimeStamp.setSelected(prefs.getBoolean(JabRefPreferences.USE_TIME_STAMP));
-        useTimeStamp.getOnAction().handle(new ActionEvent()); // pretend we just clicked on the checkbox so it updates the UI
+        setDisableUpdateTimeStamp();
         overwriteTimeStamp.setSelected(prefs.getBoolean(JabRefPreferences.OVERWRITE_TIME_STAMP));
         updateTimeStamp.setSelected(prefs.getBoolean(JabRefPreferences.UPDATE_TIMESTAMP));
         updateTimeStamp.setSelected(useTimeStamp.isSelected());