Merge remote-tracking branch 'upstream/master' into maintable-beta

* upstream/master:
  Fix ACM fetcher import of entries (#4019)
  Update Dependencies (#4012)

CHANGELOG.md

@@ -18,6 +18,8 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 We fixed an issue where the export to clipboard functionality could not be invoked [#3994](https://github.com/JabRef/jabref/issues/3994)
 We fixed an issue with the migration of invalid Look and Feels [#3995, comment](https://github.com/JabRef/jabref/issues/3995#issuecomment-385649448)
 We fixed an issue where JabRef would no longer start, when the option "Override default font settings" was activated [#3986](https://github.com/JabRef/jabref/issues/3986)
+We fixed an issue where fetched entries from the ACM fetcher could not be imported. [#4018](https://github.com/JabRef/jabref/issues/4018)
+
 ### Removed
 We removed the GTK Look and Feel from the Options, as it leads to freezes in JabRef on MacOSX and Linux [#3995](https://github.com/JabRef/jabref/issues/3995)
 The GTK Look and Feel is now replaced with the "Nimbus" style as default.

build.gradle

@@ -150,14 +150,14 @@ dependencies {
 
     compile 'com.github.tomtung:latex2unicode_2.12:0.2.2'
 
-    compile group: 'com.microsoft.azure', name: 'applicationinsights-core', version: '2.0.2'
-    compile group: 'com.microsoft.azure', name: 'applicationinsights-logging-log4j2', version: '2.0.2'
-
-    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.2.0-RC1'
-    testCompile 'org.junit.jupiter:junit-jupiter-params:5.2.0-RC1'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.2.0-RC1'
-    testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.2.0-RC1'
-    testCompile 'org.junit.platform:junit-platform-launcher:1.2.0-RC1'
+    compile group: 'com.microsoft.azure', name: 'applicationinsights-core', version: '2.1.0'
+    compile group: 'com.microsoft.azure', name: 'applicationinsights-logging-log4j2', version: '2.1.0'
+
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.2.0'
+    testCompile 'org.junit.jupiter:junit-jupiter-params:5.2.0'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.2.0'
+    testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.2.0'
+    testCompile 'org.junit.platform:junit-platform-launcher:1.2.0'
     testRuntime 'org.apache.logging.log4j:log4j-core:2.11.0'
     testRuntime 'org.apache.logging.log4j:log4j-jul:2.11.0'
     testCompile 'org.mockito:mockito-core:2.18.3'
@@ -170,7 +170,7 @@ dependencies {
     testCompile "org.testfx:testfx-core:4.0.+"
     testCompile "org.testfx:testfx-junit5:4.0.+"
 
-    checkstyle 'com.puppycrawl.tools:checkstyle:8.9'
+    checkstyle 'com.puppycrawl.tools:checkstyle:8.10'
 }
 
 jacoco {

src/main/java/org/jabref/gui/importer/fetcher/ACMPortalFetcher.java

@@ -78,7 +78,7 @@ public class ACMPortalFetcher implements PreviewEntryFetcher {
 
     private static final Pattern FULL_CITATION_PATTERN = Pattern.compile("<a href=\"(citation.cfm.*)\" target.*");
 
-    private static final Pattern ID_PATTERN = Pattern.compile("citation.cfm\\?id=(\\d+)&.*");
+    private static final Pattern ID_PATTERN = Pattern.compile("citation.cfm\\?id=(\\d+).*");
 
     // Patterns used to extract information for the preview:
     private static final Pattern TITLE_PATTERN = Pattern.compile("<a href=.*?\">([^<]*)</a>");