Skip to content

Commit

Permalink
Remove CCS as it is no longer available (#10270)
Browse files Browse the repository at this point in the history
* Remove CCS as it is no longer available


Fixes #10258

* revert formatters

* fix checkstyle

* fix tests

* fix test
  • Loading branch information
Siedlerchr authored Sep 1, 2023
1 parent 6650f84 commit 61eeb51
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We removed support for Markdown syntax for strikethrough and task lists in comment fields. [#9726](https://github.com/JabRef/jabref/pull/9726)
- We removed the options menu, because the two contents were moved to the File menu or the properties of the library. [#9768](https://github.com/JabRef/jabref/pull/9768)
- We removed the 'File' tab in the preferences and moved its contents to the 'Export' tab. [#9839](https://github.com/JabRef/jabref/pull/9839)
- We removed the "[Collection of Computer Science Bibliographies](https://en.wikipedia.org/wiki/Collection_of_Computer_Science_Bibliographies)" fetcher the websits is no longer available. [#6638](https://github.com/JabRef/jabref/issues/6638)

## [5.9] - 2023-01-06

Expand Down
5 changes: 2 additions & 3 deletions src/main/java/org/jabref/logic/importer/WebFetchers.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import org.jabref.logic.importer.fetcher.BiodiversityLibrary;
import org.jabref.logic.importer.fetcher.BvbFetcher;
import org.jabref.logic.importer.fetcher.CiteSeer;
import org.jabref.logic.importer.fetcher.CollectionOfComputerScienceBibliographiesFetcher;
import org.jabref.logic.importer.fetcher.CompositeSearchBasedFetcher;
import org.jabref.logic.importer.fetcher.CrossRef;
import org.jabref.logic.importer.fetcher.CustomizableKeyFetcher;
Expand Down Expand Up @@ -110,11 +109,11 @@ public static SortedSet<SearchBasedFetcher> getSearchBasedFetchers(ImportFormatP
set.add(new DBLPFetcher(importFormatPreferences));
set.add(new SpringerFetcher(importerPreferences));
set.add(new CrossRef());
set.add(new CiteSeer());
set.add(new CiteSeer());
set.add(new DOAJFetcher(importFormatPreferences));
set.add(new IEEE(importFormatPreferences, importerPreferences));
set.add(new CompositeSearchBasedFetcher(set, 30));
set.add(new CollectionOfComputerScienceBibliographiesFetcher(importFormatPreferences));
// set.add(new CollectionOfComputerScienceBibliographiesFetcher(importFormatPreferences));
set.add(new DOABFetcher());
// set.add(new JstorFetcher(importFormatPreferences));
set.add(new SemanticScholar());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public void emptyStudyConstructorFillsDatabasesCorrectly() {
new StudyCatalogItem("Bibliotheksverbund Bayern (Experimental)", false),
new StudyCatalogItem("Biodiversity Heritage", false),
new StudyCatalogItem("CiteSeerX", false),
new StudyCatalogItem("Collection of Computer Science Bibliographies", false),
new StudyCatalogItem("Crossref", false),
new StudyCatalogItem("DBLP", true),
new StudyCatalogItem("DOAB", false),
Expand Down Expand Up @@ -80,7 +79,6 @@ public void studyConstructorFillsDatabasesCorrectly(@TempDir Path tempDir) {
new StudyCatalogItem("Bibliotheksverbund Bayern (Experimental)", false),
new StudyCatalogItem("Biodiversity Heritage", false),
new StudyCatalogItem("CiteSeerX", false),
new StudyCatalogItem("Collection of Computer Science Bibliographies", false),
new StudyCatalogItem("Crossref", false),
new StudyCatalogItem("DBLP", false),
new StudyCatalogItem("DOAB", false),
Expand Down
4 changes: 3 additions & 1 deletion src/test/java/org/jabref/logic/importer/WebFetchersTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.util.stream.Collectors;

import org.jabref.logic.importer.fetcher.AbstractIsbnFetcher;
import org.jabref.logic.importer.fetcher.CollectionOfComputerScienceBibliographiesFetcher;
import org.jabref.logic.importer.fetcher.GoogleScholar;
import org.jabref.logic.importer.fetcher.GrobidCitationFetcher;
import org.jabref.logic.importer.fetcher.GvkFetcher;
Expand Down Expand Up @@ -77,10 +78,10 @@ void getIdBasedFetchersReturnsAllFetcherDerivingFromIdBasedFetcher() {
expected.remove(EbookDeIsbnFetcher.class);
expected.remove(GvkFetcher.class);
expected.remove(DoiToBibtexConverterComIsbnFetcher.class);

// Remove the following, because they don't work at the moment
expected.remove(JstorFetcher.class);
expected.remove(GoogleScholar.class);
expected.remove(CollectionOfComputerScienceBibliographiesFetcher.class);

assertEquals(expected, getClasses(idFetchers));
}
Expand Down Expand Up @@ -120,6 +121,7 @@ void getSearchBasedFetchersReturnsAllFetcherDerivingFromSearchBasedFetcher() {
// Remove the following, because they don't work atm
expected.remove(JstorFetcher.class);
expected.remove(GoogleScholar.class);
expected.remove(CollectionOfComputerScienceBibliographiesFetcher.class);

expected.remove(PagedSearchBasedParserFetcher.class);
expected.remove(PagedSearchBasedFetcher.class);
Expand Down

0 comments on commit 61eeb51

Please sign in to comment.