Apply css files correctly to dialogs

Fixes #6039.
JabRef · Aug 31, 2020 · 5bc1792 · 5bc1792
1 parent dfefd4d
commit 5bc1792
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 ### Changed
 
 ### Fixed
+- We fixed the wrong behavior that font size changes are not reflected in dialogs. [#6039](https://github.com/JabRef/jabref/issues/6039)
 
 ### Removed
 

diff --git a/src/main/java/org/jabref/gui/util/BaseDialog.java b/src/main/java/org/jabref/gui/util/BaseDialog.java
@@ -2,6 +2,7 @@
 
 import java.util.Optional;
 
+import javafx.scene.Node;
 import javafx.scene.control.Button;
 import javafx.scene.control.ButtonType;
 import javafx.scene.control.Dialog;
@@ -14,6 +15,8 @@
 import org.jabref.gui.keyboard.KeyBinding;
 import org.jabref.gui.keyboard.KeyBindingRepository;
 
+import com.tobiasdiez.easybind.EasyBind;
+
 public class BaseDialog<T> extends Dialog<T> implements org.jabref.gui.Dialog<T> {
 
     protected BaseDialog() {
@@ -36,7 +39,9 @@ protected BaseDialog() {
 
         setDialogIcon(IconTheme.getJabRefImageFX());
         setResizable(true);
-        Globals.getThemeLoader().installCss(getDialogPane().getScene(), Globals.prefs);
+        EasyBind.wrapNullable(dialogPaneProperty())
+                .mapObservable(Node::sceneProperty)
+                .subscribeToValues(scene -> Globals.getThemeLoader().installCss(scene, Globals.prefs));
     }
 
     private Optional<Button> getDefaultButton() {