Changed the messages after importing unlinked local files to past pas…

…sive tense. (#9308) * Changed messages after importing unlinked files to passive. * Changed icon for successfully import bib entry to "check" icon. * Changed messages after importing to past passive tense. * Modified CHANGLOG.md to reflect the change. Co-authored-by: Christoph <[email protected]> Co-authored-by: ThiloteE <[email protected]>
JabRef · Oct 28, 2022 · 3ca07bf · 3ca07bf
1 parent 2404578
commit 3ca07bf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -48,6 +48,8 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We changed the color of found text from red to high-contrast colors (background: yellow; font color: purple). [koppor#552](https://github.com/koppor/jabref/issues/552)
 - We modified the "Delete file" dialog and add the full file path to the dialog text. The file path in the title was changed to file name only. [koppor#534](https://github.com/koppor/jabref/issues/534)
 - Download from URL now automatically fills with URL from clipboard. [koppor#535](https://github.com/koppor/jabref/issues/535)
+- We changed the messages after importing unlinked local files to past passive tense. [koppor#548](https://github.com/koppor/jabref/issues/548)
+- We fixed an issue where the wrong icon for a successful import of a bib entry was shown [koppor#548](https://github.com/koppor/jabref/issues/548)
 
 ### Fixed
 

diff --git a/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java b/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java
@@ -119,10 +119,10 @@ protected List<ImportFilesResultItemViewModel> call() {
 
                             if (!pdfEntriesInFile.isEmpty()) {
                                 entriesToAdd.addAll(pdfEntriesInFile);
-                                addResultToList(file, true, Localization.lang("Importing using extracted PDF data"));
+                                addResultToList(file, true, Localization.lang("File was successfully imported as a new entry"));
                             } else {
                                 entriesToAdd.add(createEmptyEntryWithLink(file));
-                                addResultToList(file, false, Localization.lang("No metadata found. Creating empty entry with file link"));
+                                addResultToList(file, false, Localization.lang("No metadata was found. An empty entry was created with file link"));
                             }
                         } else if (FileUtil.isBibFile(file)) {
                             var bibtexParserResult = contentImporter.importFromBibFile(file, fileUpdateMonitor);
@@ -131,10 +131,10 @@ protected List<ImportFilesResultItemViewModel> call() {
                             }
 
                             entriesToAdd.addAll(bibtexParserResult.getDatabaseContext().getEntries());
-                            addResultToList(file, false, Localization.lang("Importing bib entry"));
+                            addResultToList(file, true, Localization.lang("Bib entry was successfully imported"));
                         } else {
                             entriesToAdd.add(createEmptyEntryWithLink(file));
-                            addResultToList(file, false, Localization.lang("No BibTeX data found. Creating empty entry with file link"));
+                            addResultToList(file, false, Localization.lang("No BibTeX data was found. An empty entry was created with file link"));
                         }
                     } catch (IOException ex) {
                         LOGGER.error("Error importing", ex);

diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -2321,10 +2321,10 @@ Error\ importing.\ See\ the\ error\ log\ for\ details.=Error importing. See the
 
 Error\ from\ import\:\ %0=Error from import\: %0
 Error\ reading\ PDF\ content\:\ %0=Error reading PDF content\: %0
-Importing\ bib\ entry=Importing bib entry
-Importing\ using\ extracted\ PDF\ data=Importing using extracted PDF data
-No\ BibTeX\ data\ found.\ Creating\ empty\ entry\ with\ file\ link=No BibTeX data found. Creating empty entry with file link
-No\ metadata\ found.\ Creating\ empty\ entry\ with\ file\ link=No metadata found. Creating empty entry with file link
+Bib\ entry\ was\ successfully\ imported=Bib entry was successfully imported
+File\ was\ successfully\ imported\ as\ a\ new\ entry=File was successfully imported as a new entry
+No\ BibTeX\ data\ was\ found.\ An\ empty\ entry\ was\ created\ with\ file\ link=No BibTeX data was found. An empty entry was created with file link
+No\ metadata\ was\ found.\ An\ empty\ entry\ was\ created\ with\ file\ link=No metadata was found. An empty entry was created with file link
 Processing\ file\ %0=Processing file %0
 Export\ selected=Export selected