Skip to content

Commit

Permalink
Use python raw string to preserve all special characters (#5589)
Browse files Browse the repository at this point in the history
in bibtex json when importing from web extension.
  • Loading branch information
LyzardKing authored and koppor committed Nov 11, 2019
1 parent d1484f8 commit 03c1029
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions buildres/linux/jabrefHost.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ def send_message(message):


def add_jabref_entry(data):
cmd = f'{str(JABREF_PATH)} --importBibtex """{data}"""'
"""Send string via cli as literal to preserve special characters"""
cmd = [str(JABREF_PATH), "--importBibtex", r"{}".format(data)]
logging.info(f"Try to execute command {cmd}")
try:
response = subprocess.check_output(shlex.split(cmd), stderr=subprocess.STDOUT)
response = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as exc:
logging.error(f"Failed to call JabRef: {exc.returncode} {exc.output}")
else:
Expand All @@ -78,9 +79,9 @@ def add_jabref_entry(data):
logging.info(str(message))

if "status" in message and message["status"] == "validate":
cmd = str(JABREF_PATH) + " -version"
cmd = [str(JABREF_PATH), "--version"]
try:
response = subprocess.check_output(shlex.split(cmd), stderr=subprocess.STDOUT)
response = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as exc:
logging.error(f"Failed to call JabRef: {exc.returncode} {exc.output}")
send_message({"message": "jarNotFound", "path": JABREF_PATH})
Expand Down

0 comments on commit 03c1029

Please sign in to comment.