Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked "Do not ask again" does not work #566

Closed
koppor opened this issue May 20, 2022 · 21 comments · Fixed by JabRef/jabref#12034
Closed

Unchecked "Do not ask again" does not work #566

koppor opened this issue May 20, 2022 · 21 comments · Fixed by JabRef/jabref#12034

Comments

@koppor
Copy link
Member

koppor commented May 20, 2022

  1. Reset JabRef preferences
  2. Restart JabRef
  3. Start Import:
    grafik
  4. Choose metaData.pdf from src\test\resources\pdfs
    grafik
  5. JabRef asks for "Remote services"
    grafik
    grafik
  6. Click "yes"
  7. Cancel the import
    grafik
  8. Import the PDF again (steps 3 and 4)
  9. Expected: Dialog appears. However, the PDF is parsed as is (and no dialog is appearing)
    grafik
@koppor koppor changed the title "Do not ask again" does not function "Do not ask again" does not work May 23, 2022
@ThiloteE ThiloteE moved this to Free to take in Good First Issues Oct 14, 2022
@DunkDoge
Copy link

Hi, can I work on this issue? I'm in a uni group and we've been tasked with contributing to open source software

DunkDoge referenced this issue in DunkDoge/jabref Oct 23, 2022
@ThiloteE ThiloteE moved this from Free to take to In Progress in Good First Issues Oct 25, 2022
@koppor koppor changed the title "Do not ask again" does not work Unchecked "Do not ask again" does not work Nov 7, 2022
@koppor
Copy link
Member Author

koppor commented Jan 3, 2023

A huge discussion was going on at JabRef#9291.

Decision:

Preferences: Radio-Button-Group for Grobid: enable grobid, disable grobid, always ask for confirmation (source: JabRef#9291 (comment))

(No "DoNotAskAgain" button)

Open point: Link to privacy statement. This can be ommitted in the PR.

@koppor koppor moved this from In Progress to Free to take in Good First Issues Jan 4, 2023
@hanachaari
Copy link

Hi everyone ! I want to work on this issue.

@hanachaari
Copy link

I am changing Gorbid preferences section into a radio-button-group. But the text property could not be resolved.
image
I tried to add new labels, but I could not find the right folder in the project.

@koppor
Copy link
Member Author

koppor commented Mar 22, 2023

You are working on strings shown to the user. These strings are also localized, because JabRef supports localization. Please read on at https://devdocs.jabref.org/code-howtos/localization.html for that topic. I think, this will help you to resolve the issue.

@hanachaari
Copy link

The link was helpful. I added the strings to "JabRef_en.properties" and the problem was resolved.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Mar 26, 2023
@hanachaari

This comment was marked as resolved.

@hanachaari
Copy link

hanachaari commented Apr 24, 2023

I want to confirm that we will omit the "do not ask again" checkbox as mentioned in this comment #566 (comment) @koppor . From a UX perspective, it would be better to keep it.

@koppor
Copy link
Member Author

koppor commented Apr 27, 2023

Question answered at JabRef#9801 (comment).

@hanachaari
Copy link

I have updated my branch with commits and updates made in the original repository . When I run it, I had this error.
image
I checked the imported files, indeed they don't exist in "src\main\java\org\jabref\logic\exporter\ModsExporter.java"
image
but rather in src-gen\main\java\org\jabref\logic\importer\fileformat\mods
image

@koppor
Copy link
Member Author

koppor commented Apr 28, 2023

Execute "clean" and then "classes" task in gradle:

image

@ThiloteE ThiloteE moved this from Reserved to In Progress in Good First Issues May 22, 2023
@calixtus calixtus moved this from In Progress to Free to take in Good First Issues Jul 3, 2023
@SUPWEZZ
Copy link

SUPWEZZ commented Oct 19, 2023

Hi, I would like the work on the issue, please assign it to me if possible!

@colinldbd
Copy link

Hi, is this issue be worked on? If not, can you please assign this issue to me? I'm a new contributor and learning how to contribute to open source projects.

@koppor
Copy link
Member Author

koppor commented Oct 20, 2023

@SUPWEZZ This time, you were quicker than @colinldbd, so I assign @SUPWEZZ

@koppor koppor moved this from Free to take to Reserved in Good First Issues Oct 20, 2023
@koppor
Copy link
Member Author

koppor commented Oct 20, 2023

@SUPWEZZ This is a really hard issue, because it is not that much about implementation, but understanding what the current request is. Please go through the discussions, especially JabRef#9801 (comment)

Maybe, it would help to create a MADR document for the options to structure the possibilities.

@SUPWEZZ
Copy link

SUPWEZZ commented Oct 24, 2023

Hi @koppor, sorry about that I'm a little confused. I just noticed I was being unassigned in two issues, but I would like to request one issue. I would like to ask compare it with "Import by id: cancel doesn't really cancel the request JabRef#10508" and "uncheck Do not ask again" Which issue is more suitable for beginners?

@koppor
Copy link
Member Author

koppor commented Oct 24, 2023

@SUPWEZZ Both are more harder. For an easy one, I would recommend you to volunteer for JabRef#10569

@koppor
Copy link
Member Author

koppor commented Oct 24, 2023

@SUPWEZZ Based on the comment at JabRef#10569 (comment), I assign you here. - Not that I did not an unassignment, you can choose whatever you want. The only condition is that the issue is not already assigned to someone else.

Now, please focus on this one. Follow my recommendation at #566 (comment), which I gave you 5 days ago.

@ThiloteE ThiloteE moved this from Reserved to Free to take in Good First Issues May 20, 2024
@arshchawla21
Copy link

Hello Maintainers, I am a second year CS major who would love to opportunity to take on this issue! I have been able to successfully reproduce the problem, and have also spent time analysing previous work on the topic.

@koppor
Copy link
Member Author

koppor commented Oct 14, 2024

@arshchawla21 Thank you for choosing this task. I assigned you and I am looking forward to your contribution!

@ThiloteE
Copy link
Member

I suppose this issue was fixed by JabRef#12034?
Closing then.

@github-project-automation github-project-automation bot moved this from Free to take to Done in Good First Issues Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment