Fix atomic outputstream closed channels exceptions (and update JavaFX) (

JabRef#11216) * Update to javafx 22.0.1 fix atomic outputstream closed channels exceptions * checkstyle
JabRef · Apr 17, 2024 · 6789460 · 6789460
1 parent 7063d2d
commit 6789460
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -122,7 +122,7 @@ dependencyLocking {
 }
 
 javafx {
-    version = "22"
+    version = "22.0.1"
     modules = [ 'javafx.controls', 'javafx.fxml', 'javafx.web', 'javafx.swing' ]
 }
 

diff --git a/src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java b/src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java
@@ -166,12 +166,11 @@ public void abort() {
 
     private void cleanup() {
         try {
-            if (temporaryFileLock != null) {
+            if (temporaryFileLock != null && temporaryFileLock.isValid()) {
                 temporaryFileLock.release();
             }
         } catch (IOException exception) {
-            // Currently, we always get the exception:
-            // Unable to release lock on file C:\Users\koppor\AppData\Local\Temp\junit11976839611279549873\error-during-save.txt.tmp: java.nio.channels.ClosedChannelException
+            // In case we still get an exception
             LOGGER.debug("Unable to release lock on file {}", temporaryFile, exception);
         }
         try {