Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to lucia v3 #2335

Closed
wants to merge 8 commits into from
Closed

chore: migrate to lucia v3 #2335

wants to merge 8 commits into from

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Feb 6, 2024 •
edited
Loading

Todo:

  • Implement pepper for password
  • Normalize cookie names (or remove snapshot test for now)
  • Fix linter
  • Introduce public session interface for the data stored in the session cookie

Follow-up:

@tobiasdiez tobiasdiez mentioned this pull request Feb 7, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2024 •
edited
Loading

Deployed 0887c26 to https://gentle-forest-03418aa03-2335.westeurope.3.azurestaticapps.net

@tobiasdiez tobiasdiez mentioned this pull request Jul 6, 2024
Closed
@tobiasdiez tobiasdiez added the status: for future Something we cannot or shouldn't work on right now label Jul 10, 2024
@tobiasdiez tobiasdiez closed this Jul 10, 2024
@tobiasdiez tobiasdiez reopened this Aug 2, 2024
@tobiasdiez tobiasdiez removed the status: for future Something we cannot or shouldn't work on right now label Aug 2, 2024
@tobiasdiez tobiasdiez mentioned this pull request Oct 3, 2024
Merged
@tobiasdiez
Copy link
Member Author

Closing in favor of #2546

@tobiasdiez tobiasdiez closed this Oct 3, 2024
tobiasdiez added a commit that referenced this pull request Oct 4, 2024
@tobiasdiez
chore: migrate from lucia to nuxt-auth-utils (#2546)
bd2e82b 
<!--
☝️ PR title should follow conventional commits
(https://conventionalcommits.org).
In particular, the title should start with one of the following types:

- docs: 📖 Documentation (updates to the documentation or readme)
- fix: 🐞 Bug fix (a non-breaking change that fixes an issue)
- feat: ✨ New feature/enhancement (a non-breaking change that adds
functionality or improves existing one)
- feat!/fix!: ⚠️ Breaking change (fix or feature that would cause
existing functionality to change)
- chore: 🧹 Chore (updates to the build process or auxiliary tools and
libraries)
-->

### 🔗 Linked issue

<!-- If it resolves an open issue, please link the issue here. For
example "Resolves #123" -->

### 📚 Description

Reasons:
- Lucia mainly handles session management, but for this nuxt has h3
- nuxt-auth provides better integration with nuxt
- nuxt-auth provides passkey etc
- Lucia has some conventions that make it hard to work around it
(especially the whole "prisma adapter" thing, that is not quite working
well) - doesn't get really better with v4 see
#2335

<!-- Describe your changes in detail -->
<!-- Why is this change required? What problem does it solve? -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobiasdiez