Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that jabreHost.py needs to be executable #127

Closed

Conversation

joelostblom
Copy link

I installed jabref-latest via pacman in Arch and then installed the JabFox extension through Mozilla's addon website. The addon would get stuck on Send to JabRef... and in Firefox in the JabFox preferences, I would see Error: Attempt to postMessage on disconnected port.

I had to make the change indicated in this PR and set executable bit of /opt/JabRef/lib/jabrefHost.py manually (I noticed this is already the case in the main repo, but it was not in the file installed on my system).

Related to #110 and #75.

@LyzardKing
Copy link
Collaborator

Jabref upstream uses all lowercase, so it's an issue in the AUR PKGBUILD.
The issue is that it's using the tarfile (that has the uppercase).
The deb/rpm, that are built with jpackage, use the lowercase (same as the package name).
I think the issue should be solved in the AUR package

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! One small suggestion, then we can merge.

README.md Outdated
3. Download [org.jabref.jabref.json](https://raw.githubusercontent.com/JabRef/jabref/master/buildres/linux/native-messaging-host/firefox/org.jabref.jabref.json) and put it into
- `/usr/lib/mozilla/native-messaging-hosts/org.jabref.jabref.json` to install with admin rights for all users
- `~/.mozilla/native-messaging-hosts/org.jabref.jabref.json` to install without admin rights for the current user
4. Ensure that the script `/opt/JabRef/lib/jabrefHost.py` is marked as executable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a small note pointing out that the path in the json maybe needs to be corrected as well. The path in step 4 then needs to be changed accordingly.

@joelostblom
Copy link
Author

Thanks for the explanation! I suggested changes to the aur PKBUILD.

To avoid that people installing directly from the tarball or using it as a basis for creating a package will run into these problem, would an option be to change the generated tarball name from JabRef to jabref? Then additional note that I just added would be superfluous as well, but maybe this would cause issues elsewhere?

@tobiasdiez
Copy link
Member

@joelostblom @LyzardKing sorry for the long silence on my part. Is this still an issue with JabRef 5.0 which was released very recently?

@LyzardKing
Copy link
Collaborator

I don't think so.
It should have been fixed a while back.

@tobiasdiez
Copy link
Member

Ok, then I'm closing this PR now. @joelostblom Thanks a lot for your contribution nonetheless. (If the issue does persist, please feel free to reopen this PR and ping me.)

@tobiasdiez tobiasdiez closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants