-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new functions/methods to featurize module #330
base: main
Are you sure you want to change the base?
Conversation
Hi @JaGeo, there seems to be some issue with coverage artificats not being generated and uploaded in CI, I have not been able to pinpoint the cause yet. Will check again in detail tomorrow. Leaving this as a comment only for my reference here. |
Could be simply bug associated with a new release of pytest today. Will have to check downgrading it |
@naik-aakash sure. Don't worry! |
issue was with upload artificats update ignoring hidden files from being uploaded. It should be fixed now in PR #331 |
|
||
return df | ||
|
||
def get_stats_df(self, ids: str | None = None) -> pd.DataFrame: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @naik-aakash another BWDF featurization that avoids many zero entries could be (a) a list of distances ordered by BWDF value, descending or (b) a list of BWDF values ordered by distances, ascending. If you are interested, i'm happy to add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sounds like a very good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaueltzen for this suggestion. Could be nice to also test this out. I have now pushed the changes to repo, you can add it to this branch
…stance, ascending and modified pyprject.toml to ignore EXE002
… (considering only positive OR negative BWDF values)
…atgen should fix it automatically)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allen is a name and therefore written with capital A 😃
Co-authored-by: Christina Ertural <[email protected]>
Co-authored-by: Christina Ertural <[email protected]>
Closes #329
Changes