Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new functions/methods to featurize module #330

Draft
wants to merge 96 commits into
base: main
Choose a base branch
from

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Sep 10, 2024

Closes #329

Changes

  • Add ultiliy functions to compute reduced masses, electronegativity and sort dict by values
  • Add the possibility to modify default lobsterpy kwargs in featurizers
  • Add ICOXX featurizer with BWDF functionality
  • Get BWDF statistical features
  • Investigate incosistencies in translation vectors wrt bond distances in ICOXXLIST.lobster (result :-> only inconsistent if POSCAR is read, it is consistent when CONTCAR/POSCAR.lobster/POSCAR.lobster.vasp is read)
  • Make CONTCAR as default file to read in automatic analysis and featurizers (translations are then consistent with lobster files)
  • Add tests

@naik-aakash naik-aakash marked this pull request as draft September 10, 2024 15:44
@naik-aakash naik-aakash self-assigned this Sep 10, 2024
@naik-aakash naik-aakash added the enhancement New feature or request label Sep 10, 2024
@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo, there seems to be some issue with coverage artificats not being generated and uploaded in CI, I have not been able to pinpoint the cause yet. Will check again in detail tomorrow. Leaving this as a comment only for my reference here.

@naik-aakash
Copy link
Collaborator Author

Could be simply bug associated with a new release of pytest today. Will have to check downgrading it

@JaGeo
Copy link
Owner

JaGeo commented Sep 10, 2024

@naik-aakash sure. Don't worry!

@naik-aakash
Copy link
Collaborator Author

@naik-aakash sure. Don't worry!

issue was with upload artificats update ignoring hidden files from being uploaded. It should be fixed now in PR #331

@naik-aakash naik-aakash marked this pull request as ready for review September 16, 2024 12:39
@naik-aakash naik-aakash changed the title [WIP] add new functions/methods to featurize module Add new functions/methods to featurize module Sep 16, 2024
@naik-aakash naik-aakash requested a review from JaGeo September 16, 2024 12:40
@naik-aakash naik-aakash marked this pull request as draft September 17, 2024 09:08
@naik-aakash naik-aakash marked this pull request as ready for review December 8, 2024 11:23
@naik-aakash naik-aakash marked this pull request as draft December 10, 2024 06:47

return df

def get_stats_df(self, ids: str | None = None) -> pd.DataFrame:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naik-aakash another BWDF featurization that avoids many zero entries could be (a) a list of distances ordered by BWDF value, descending or (b) a list of BWDF values ordered by distances, ascending. If you are interested, i'm happy to add that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sounds like a very good idea.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaueltzen for this suggestion. Could be nice to also test this out. I have now pushed the changes to repo, you can add it to this branch

Copy link
Contributor

@QuantumChemist QuantumChemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allen is a name and therefore written with capital A 😃

src/lobsterpy/featurize/utils.py Outdated Show resolved Hide resolved
src/lobsterpy/featurize/utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update featurizer module with more options
4 participants