Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impls for serde_json and rmp-serde #18

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

the10thWiz
Copy link
Collaborator

No description provided.

@the10thWiz the10thWiz requested a review from JRRudy1 September 8, 2024 21:10
Copy link
Owner

@JRRudy1 JRRudy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!! I'll make the two minor changes I mentioned and then merge.

Removed wildcard imports in favor of explicit paths.
@JRRudy1
Copy link
Owner

JRRudy1 commented Sep 8, 2024

@the10thWiz thanks again for the contributions! I'll go ahead and publish a new release to crates.io. I don't think there are any breaking changes, in which case I'll just bump to v0.4.1.

@JRRudy1 JRRudy1 merged commit bb3741c into JRRudy1:main Sep 8, 2024
6 checks passed
@the10thWiz the10thWiz deleted the serde-types branch September 9, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants