MSRV bump to 1.60, MSRV compliance fix, and CI updates #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the MSRV has being set to 1.56, the crate re-exports
std::any::type_name_of_valwhich wasn't stabilized until rustc 1.76. This PR adds a conditional compilation gate to this re-export to properly compile on v1.56. This requires adding a compile-time-only dependency on therustversioncrate, which should be lightweight enough to be harmless.However, another issue is that the "dep:" syntax in Cargo.toml was not stabilized until rustc 1.60. Working around this would be annoying due to feature/dependency name conflicts, so instead this PR includes an MSRV bump to 1.60 which should still be old enough for the vast majority of crates to support.
Finally, the CI has been updated to build the crate with a rustc version below the
type_name_of_valcutoff, which would ideally be the MSRV. However, updating the crates.io registry is crazy slow for versions below 1.68 when the sparse protocol was implemented, so this version will be used in the CI instead. Note that the CI will not run tests for this version due to higher MSRV for thetry-builddev dependency, but building the crate should be good enough to catch MSRV violations.