Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix2f.mulComponentWise(Matrix2f) incorrectly calls Matrix2f.sub(Matrix2f, Matrix2f) #310

Closed
TheIceCreamBear opened this issue Feb 16, 2022 · 1 comment
Closed

Matrix2f.mulComponentWise(Matrix2f) incorrectly calls Matrix2f.sub(Matrix2f, Matrix2f) #310

TheIceCreamBear opened this issue Feb 16, 2022 · 1 comment
Labels
bug
Milestone
1.10.5 release

Comments

@TheIceCreamBear
Copy link

The title pretty much says all there is about this issue. Line 1415 of src/org/joml/Matrix2f.java incorrectly calls return sub(other, this) instead of the method appropriate return mulComponentWise(other, this)

Link for reference: Matrix2f#L1415
httpdigest added a commit that referenced this issue Feb 17, 2022
@httpdigest
Fix Matrix2.mulComponentWise() (#310)
6c98846
@httpdigest httpdigest added the bug label Feb 17, 2022
@httpdigest
Copy link
Member

Thanks for reporting!

@httpdigest httpdigest added this to the 1.10.5 release milestone Feb 17, 2022
httpdigest added a commit that referenced this issue Feb 17, 2022
@httpdigest
Fix Matrix2.mulComponentWise() (#310)
44177d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.10.5 release
Development

No branches or pull requests
2 participants
@httpdigest @TheIceCreamBear