Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not implement cloneable interface for vector and matrix? #279

Closed
zhouhang95 opened this issue Feb 12, 2021 · 3 comments
Closed

Why not implement cloneable interface for vector and matrix? #279

zhouhang95 opened this issue Feb 12, 2021 · 3 comments
Labels
enhancement
Milestone
1.10.1 release

Comments

@zhouhang95
Copy link

As, title.
@XenoAmess
Copy link
Contributor

Cloneable is not recommended.

httpdigest added a commit that referenced this issue Feb 12, 2021
@httpdigest
Implement Cloneable for all classes (#279)
2236936
@httpdigest
Copy link
Member

There is no reason, why the classes currently didn't implement Cloneable. There simply wasn't anyone asking for it, until now.
Added with 2236936

@httpdigest httpdigest added this to the 1.10.1 release milestone Feb 12, 2021
@zhouhang95
Copy link
Author

Thank you.
I think it's more handy that "p.clone()" in palce of "new Vector3f(p)".

@dependabot dependabot bot mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.10.1 release
Development

No branches or pull requests
3 participants
@httpdigest @zhouhang95 @XenoAmess