Add support for pinterest package and group changes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is only required when using version 0.32.0, I haven't changed the sample repo. Added test that checks that the correct dependency is added.
tasomaniac
commented
Apr 23, 2019
Tapchicoma
reviewed
Apr 23, 2019
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/KtlintApplyToIdeaTask.kt
Outdated
Show resolved
Hide resolved
|
@tasomaniac can you also update ## [Unreleased]
### Changed
- Default ktlint version to `0.32.0`.
Add support different group/package name (#228) |
Tapchicoma
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ktlint just released version 0.32.0 to fix a problem with Kotlin 1.3.30. But at the same time, they also changed the maven group id and package names. That is why just updating ktlint version to
0.32.0breaks ktlint plugin.Solution
I've replaces groups and packages to support the new version. These changes here should be backward compatible.
Considerations
Since this is only required when using version 0.32.0, I haven't changed the sample repo.
Added test that checks that the correct dependency is added.
Fixes #227