Decorations get toggled when window is sent to another WS, and smart_place doesn't appear to work

[broccoli5]

I really hope that this just isn't me being stupid, yet again.

For some reason, when I move a window to another workspace it toggles it's decorations, and I have to manually toggle them back on, this happens with every program. decorate_new has no effect on this. This is my keybind:

# Switch to WS / send window to WS
super + {_,shift + }{1-9,0}
	berryc {switch_workspace,send_to_workspace} {0-9}

And regarding the smart_place problem: I'm not sure if my screen resolution (1280x800) has to do anything with it, or the way that it determines whats a empty space. But no matter what I try it always places windows to the top left corner as if it was turned off, even if there are already windows there.

I'm not sure how to get any logs tho

[JLErvin]

I'll try to repro...

[JLErvin]

It looks like the decorations issues was introduced as a bug in #136, I'll look into a fix.

[broccoli5]

I had a look around and I think that I understand the problem. I'm still learning C and I haven't worked with Xorg yet. But is there a way to check if the "dummy" windows are drawn around the clients when you switch to a WS? Something like a struct inside a struct that would hold the client and state of the "dummy" window? IDK, just an idea

[JLErvin]

I know what the issue is, it’s just a matter of the simplest way to fix it. The PR I linked introduced destroying decorating when clients are moved to prevent certain errors, but this leads to the state being lost during workspace switches.

Regarding your question, yes. Clients maintain a boolean value determining whether or not they are decorated.

[willowbit]

Any update on this? Loving berry so far

[JLErvin]

Sorry, this slipped off my radar. Out of town until this weekend but will look into it when I get home.

[JLErvin]

@willowbit can you try the changes made here #143 and see if they persist decorations for you?

[willowbit]

This works wonderfully, thank you so much!

Looking forward to your work :)

[4zv4l]

Hey,
I open it again because it still happen to me, when I move a window from a workspace to another its decoration is removed.

super + shift + 1
    berryc send_to_workspace 0

that's how I send the window to another workspace in my sxhkdrc script