Change orderId type (#1325)

* Update BinanceSocketClientSpotApiTrading.cs Change type of orderId parameter in GetOrderAsync and CancelOrderAsync * Update Binance.Net.xml * Update IBinanceSocketClientSpotApiTrading.cs
JKorf · Dec 26, 2023 · 127156e · 127156e
1 parent 723a2af
commit 127156e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Binance.Net/Binance.Net.xml b/Binance.Net/Binance.Net.xml
@@ -1832,7 +1832,7 @@
         <member name="M:Binance.Net.Clients.SpotApi.BinanceSocketClientSpotApiTrading.GetOrderAsync(System.String,System.Nullable{System.Int32},System.String)">
             <inheritdoc />
         </member>
-        <member name="M:Binance.Net.Clients.SpotApi.BinanceSocketClientSpotApiTrading.CancelOrderAsync(System.String,System.Nullable{System.Int32},System.String,System.String)">
+        <member name="M:Binance.Net.Clients.SpotApi.BinanceSocketClientSpotApiTrading.CancelOrderAsync(System.String,System.Nullable{System.Int64},System.String,System.String)">
             <inheritdoc />
         </member>
         <member name="M:Binance.Net.Clients.SpotApi.BinanceSocketClientSpotApiTrading.ReplaceOrderAsync(System.String,Binance.Net.Enums.OrderSide,Binance.Net.Enums.SpotOrderType,Binance.Net.Enums.CancelReplaceMode,System.Nullable{System.Int64},System.String,System.String,System.String,System.Nullable{System.Decimal},System.Nullable{System.Decimal},System.Nullable{System.Decimal},System.Nullable{Binance.Net.Enums.TimeInForce},System.Nullable{System.Decimal},System.Nullable{System.Decimal},System.Nullable{Binance.Net.Enums.OrderResponseType},System.Nullable{System.Int32},System.Nullable{System.Int32},System.Nullable{System.Int32})">
@@ -10373,7 +10373,7 @@
             <param name="symbol">Filter by symbols</param>
             <returns></returns>
         </member>
-        <member name="M:Binance.Net.Interfaces.Clients.SpotApi.IBinanceSocketClientSpotApiTrading.GetOrderAsync(System.String,System.Nullable{System.Int32},System.String)">
+        <member name="M:Binance.Net.Interfaces.Clients.SpotApi.IBinanceSocketClientSpotApiTrading.GetOrderAsync(System.String,System.Nullable{System.Int64},System.String)">
             <summary>
             Get order by either orderId or clientOrderId
             <para><a href="https://binance-docs.github.io/apidocs/websocket_api/en/#query-order-user_data" /></para>

diff --git a/Binance.Net/Clients/SpotApi/BinanceSocketClientSpotApiTrading.cs b/Binance.Net/Clients/SpotApi/BinanceSocketClientSpotApiTrading.cs
@@ -123,7 +123,7 @@ public async Task<CallResult<BinanceResponse<BinancePlacedOrder>>> PlaceTestOrde
         #region Get Order
 
         /// <inheritdoc />
-        public async Task<CallResult<BinanceResponse<BinanceOrder>>> GetOrderAsync(string symbol, int? orderId = null, string? clientOrderId = null)
+        public async Task<CallResult<BinanceResponse<BinanceOrder>>> GetOrderAsync(string symbol, long? orderId = null, string? clientOrderId = null)
         {
             var parameters = new Dictionary<string, object>();
             parameters.AddParameter("symbol", symbol);
@@ -137,7 +137,7 @@ public async Task<CallResult<BinanceResponse<BinanceOrder>>> GetOrderAsync(strin
         #region Cancel Order
 
         /// <inheritdoc />
-        public async Task<CallResult<BinanceResponse<BinanceOrder>>> CancelOrderAsync(string symbol, int? orderId = null, string? clientOrderId = null, string? newClientOrderId = null)
+        public async Task<CallResult<BinanceResponse<BinanceOrder>>> CancelOrderAsync(string symbol, long? orderId = null, string? clientOrderId = null, string? newClientOrderId = null)
         {
             var parameters = new Dictionary<string, object>();
             parameters.AddParameter("symbol", symbol);

diff --git a/Binance.Net/Interfaces/Clients/SpotApi/IBinanceSocketClientSpotApiTrading.cs b/Binance.Net/Interfaces/Clients/SpotApi/IBinanceSocketClientSpotApiTrading.cs
@@ -39,7 +39,7 @@ public interface IBinanceSocketClientSpotApiTrading
         /// <param name="clientOrderId">Client order id</param>
         /// <param name="newClientOrderId">New client order id for the order</param>
         /// <returns></returns>
-        Task<CallResult<BinanceResponse<BinanceOrder>>> CancelOrderAsync(string symbol, int? orderId = null, string? clientOrderId = null, string? newClientOrderId = null);
+        Task<CallResult<BinanceResponse<BinanceOrder>>> CancelOrderAsync(string symbol, long? orderId = null, string? clientOrderId = null, string? newClientOrderId = null);
         /// <summary>
         /// Get an oco order by either orderId or clientOrderId
         /// <para><a href="https://binance-docs.github.io/apidocs/websocket_api/en/#account-oco-history-user_data" /></para>
@@ -79,7 +79,7 @@ public interface IBinanceSocketClientSpotApiTrading
         /// <param name="orderId">Order id</param>
         /// <param name="clientOrderId">Client order id</param>
         /// <returns></returns>
-        Task<CallResult<BinanceResponse<BinanceOrder>>> GetOrderAsync(string symbol, int? orderId = null, string? clientOrderId = null);
+        Task<CallResult<BinanceResponse<BinanceOrder>>> GetOrderAsync(string symbol, long? orderId = null, string? clientOrderId = null);
         /// <summary>
         /// Get order history
         /// <para><a href="https://binance-docs.github.io/apidocs/websocket_api/en/#account-order-history-user_data" /></para>
@@ -209,4 +209,4 @@ public interface IBinanceSocketClientSpotApiTrading
         /// <returns></returns>
         Task<CallResult<BinanceResponse<BinanceReplaceOrderResult>>> ReplaceOrderAsync(string symbol, OrderSide side, SpotOrderType type, CancelReplaceMode cancelReplaceMode, long? cancelOrderId = null, string? cancelClientOrderId = null, string? newCancelClientOrderId = null, string? newClientOrderId = null, decimal? quantity = null, decimal? quoteQuantity = null, decimal? price = null, TimeInForce? timeInForce = null, decimal? stopPrice = null, decimal? icebergQty = null, OrderResponseType? orderResponseType = null, int? trailingDelta = null, int? strategyId = null, int? strategyType = null);
     }
-}
+}