Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category collapses on rename #71

Closed
jlj-ee opened this issue Apr 11, 2018 · 2 comments
Closed

Category collapses on rename #71

jlj-ee opened this issue Apr 11, 2018 · 2 comments
Assignees
Labels

Comments

@jlj-ee
Copy link

jlj-ee commented Apr 11, 2018

Using: LabVIEW 2016 and 2013.6.0.232

Steps to reproduce:

  1. Select a category separator state in the states tree
  2. Right-click -> Rename or F2
  3. Enter name and press 'Ok'
  4. See that the category that was just renamed has been collapsed, hiding its sub-states

Mild annoyance but hardly a showstopper. I don't seem to remember this happening in older versions. It would be ideal if the tree kept the original collapsed/expanded state through the rename.
Thanks for continuing to update this great tool!

@jlj-ee
Copy link
Author

jlj-ee commented Apr 11, 2018

Actually, it seems that renaming any state (not just the category separator state) causes its category to collapse.

@jimkring jimkring self-assigned this Apr 11, 2018
@jimkring jimkring added the bug label Apr 11, 2018
@jimkring
Copy link
Contributor

Thanks for reporting this issue. It's been fixed in this release: https://github.com/JKISoftware/JKI-State-Machine-Editor/releases/tag/2013.6.1.233

jimkring added a commit that referenced this issue Aug 22, 2018
* Find_Data_Accessors: (21 commits)
  Fix for Issue #77: QuickDrop Shortcut (Ctrl+J) should work even if no items selected and BD has a JKI SM
  rebuilt
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Rebuilt after adding release notes to VIPB packaqe build spec
  - Fixed Issue #66 (Error 1055 on Cancel while adding dynamic user event), and some other cleanup
  Fix for issue #71 (Category collapses on rename)
  - Fixed issue where wires that were not string types were showing the Insert "Add State(s) to Queue" right-click option
  New Feature: Insert "Add State(s) to Queue" right-click menu on state string wires
  Improvements to code that will make it easier to handle case where Event Structure is not the first frame of the Case Structure

  Fix for Issue #69 (Suggestion: Add scrollbars and mouse wheel support to Explore States windows) Explore State String dialog now shows (and hides) the vertical scrollbar as needed
  Fixed Issue #68 (Clicking another state when VI is running throws an error and crashes the editor)
  - Fix for issue #55 "States tree auto-expands when tree refreshes"
  - Fixed issue with right-click on state strings when they were wired through or inside of nested structures
  rebuilt
  - Fixed issues with navigation that prevented the Idle/Event frame from working correctly in the navigation history
  - Improved quick filtering (search) of states, so that it correctly keeps the Core category and it's sub-items.
  - Improvements to numbering of Event Frames ([0], [1], etc.) when using the quick filter text box - Now preserves the Idle, "" Event Frame when filtering items and an Event Frame is remaining (after filtering) - Added Expand All and Collapse All right-click options to the tree view

  rebuilt
  ...
jimkring added a commit that referenced this issue Aug 22, 2018
* Find_Data_Accessors: (23 commits)
  Don't close VI Reference to queue creator/test VI when creating the queue.
  Revert "Fixed the issue of unable to launch multiple instances"
  Fix for Issue #77: QuickDrop Shortcut (Ctrl+J) should work even if no items selected and BD has a JKI SM
  rebuilt
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Fix for #74 LabVIEW Crashes Reference JKI State Machine Helper Now ensures that the JKI SM Explorer dialog is always opened in the NI.LV.Dialog application context and cleaned up some queue reference management, just in case it helps
  Rebuilt after adding release notes to VIPB packaqe build spec
  - Fixed Issue #66 (Error 1055 on Cancel while adding dynamic user event), and some other cleanup
  Fix for issue #71 (Category collapses on rename)
  - Fixed issue where wires that were not string types were showing the Insert "Add State(s) to Queue" right-click option
  New Feature: Insert "Add State(s) to Queue" right-click menu on state string wires
  Improvements to code that will make it easier to handle case where Event Structure is not the first frame of the Case Structure

  Fix for Issue #69 (Suggestion: Add scrollbars and mouse wheel support to Explore States windows) Explore State String dialog now shows (and hides) the vertical scrollbar as needed
  Fixed Issue #68 (Clicking another state when VI is running throws an error and crashes the editor)
  - Fix for issue #55 "States tree auto-expands when tree refreshes"
  - Fixed issue with right-click on state strings when they were wired through or inside of nested structures
  rebuilt
  - Fixed issues with navigation that prevented the Idle/Event frame from working correctly in the navigation history
  - Improved quick filtering (search) of states, so that it correctly keeps the Core category and it's sub-items.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants