Ensure toggleOnBindRelease doesn't enable modules when releasing the …

…bind closes MeteorDevelopment#4710, closes MeteorDevelopment#4289, closes MeteorDevelopment#4174, closes MeteorDevelopment#2782
JFronny · Jul 1, 2024 · c51867e · c51867e
1 parent 946a4ba
commit c51867e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/meteordevelopment/meteorclient/systems/modules/Modules.java b/src/main/java/meteordevelopment/meteorclient/systems/modules/Modules.java
@@ -284,7 +284,7 @@ private void onAction(boolean isKey, int value, int modifiers, boolean isPress)
         if (mc.currentScreen != null || Input.isKeyPressed(GLFW.GLFW_KEY_F3)) return;
 
         for (Module module : moduleInstances.values()) {
-            if (module.keybind.matches(isKey, value, modifiers) && (isPress || module.toggleOnBindRelease)) {
+            if (module.keybind.matches(isKey, value, modifiers) && (isPress || (module.toggleOnBindRelease && module.isActive()))) {
                 module.toggle();
                 module.sendToggledMsg();
             }