This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Add singleSelectionMode to SelectionDialog #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jagrosh
approved these changes
Oct 15, 2018
Almighty-Alpaca
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
menumodule of the JDA-Utilities library.______.Description
Currently, SelectionDialog will continue showing options when the SELECT emoji was pressed. This makes it impossible for example to edit the menu message to show results, as the Menu itself will just re-render its current option and wait for further events.
This PR adds a new Builder setting
useSingleSelectionMode(boolean)which allows for the Menu to exit after SELECT was pressed.The default behavior is the same as before: continue listening