Ensure to include stdlib.h for malloc/free #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @davedissian ! Nice catch! |
JCash
added a commit
that referenced
this pull request
Jun 3, 2018
* CI tests * Added bounding box to jcv_diagram_generate() Input points are now culled against the bounding box Added .csv support to test program * Added missing file * Windown compile fixes * Added missing include for linux * Added an examples folder * Ensure to include stdlib.h for malloc/free (#14) * Updated max number of events that can be used at the same time (#16) * Increased the maximum number of events the priority queue can have * Added test for max num events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice library! Unfortunately it wasn't building for me using VS 2017 when the implementation is defined in a cpp file until I added the missing include (however, the malloc and free functions are implicitly defined if
JC_VORONOI_IMPLEMENTATIONis defined in a C source file, which explains why it still passes CI).