Update crtm(-fix), wgrib2 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
AlexanderRichert-NOAA
requested review from
climbfuji,
srherbener and
RatkoVasic-NOAA
climbfuji
approved these changes
Jan 30, 2025
climbfuji
reviewed
Jan 31, 2025
| if name == "cflags": | ||
| if spec.satisfies("%apple-clang"): | ||
| if self.spec.compiler.name == "apple-clang": |
There was a problem hiding this comment.
@AlexanderRichert-NOAA This seems to be a bug, or at least it is causing a build error? https://github.com/JCSDA/spack-stack/actions/runs/13077825823/job/36494196074?pr=1486
Maybe the compiler name is still clang, not apple-clang, even if the spec is apple-clang?
There was a problem hiding this comment.
Did you already take care of this? I can't test it, so feel free to do whatever makes work...
There was a problem hiding this comment.
My first attempt failed, I will need to look again. Unlikely I will be able to finish this today, other things are more urgent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the crtm, crtm-fix, and wgrib2 updates included (or soon to be) in main Spack.
I checked out the files rather than cherry picking commits since the Spack commit will end up being different anyway...