Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI (MPI_Fint/mpi_comm_f2c) patch to scotch/parmetis #291

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

This PR adds a patch to scotch to fix the OpenMPI communicator segfault issue. I've tested on Hera with GCC with one of the PDLIB UFS RTs. Once this is merged, I'll update the submodule pointer in spack-stack.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! It would be nice if there was an issue/PR/commit to reference directly before line 72, but if that doesn't exist maybe just a one-liner of why that is needed?

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit a041f7d into JCSDA:release/1.4.1 Jul 3, 2023
@ulmononian
Copy link
Collaborator

sorry i didn't get you a quick review here! thanks so much for adding this, alex 🙏🏻🚀🌊

@climbfuji climbfuji deleted the scotch_mpi_patch branch July 3, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants