Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates for Intel oneAPI and consolidation of common/modules*.yaml #1200

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 12, 2024

Summary

This PR contains the following changes:

  1. Based on the functionality to merge modules_${LMOD_OR_TCL}.yaml with modules.yaml, strip out the common settings from moduels_lmod.yaml and modules_tcl.yaml and put them in modules.yaml.

  2. Additional updates for building the full unified environment with the oneAPI C/C++ compilers:

    • Add gmake, libbsd, libm to modules exclude list
    • Currently only in the blackpearl site config (once this all works, it can be moved to common/packages_oneapi.yaml): build bison, gmake, libm, libbsd with gcc. That's because bison doesn't build with oneapi (it builds but produces garbage, see bison miscompiled with %oneapi spack/spack#37172)
  3. In configs/templates/unified-dev/spack.yaml: exclude jedi-tools-env and ai-env for oneapi, similar to what's done for intel (this was also done in a previous PR, therefore just cleaning up the comments in the file).

With these changes, the unified environment builds with [email protected] with the exception of wgrib2 (see #967 and #1199)

Testing

  • CI
  • Blackpearl with oneapi and gcc

Applications affected

n/a

Systems affected

Nautilus and Blackpearl - these are the only sites that have oneapi compilers configured

Dependencies

Issue(s) addressed

More steps towards #912

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

climbfuji added 23 commits July 9, 2024 21:02
… gcc-openblas environments (py-numpy, gcc-runtime)
…pport for setting compiler for 'spack stack create env'
…dules.py and spack-ext/lib/jcsda-emc/spack-stack/tests/test_stack_create.py
…ji/spack-stack into feature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
…eature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
@climbfuji climbfuji changed the title More updates for oneAPI and consolidation of common/modules*.yaml (based on https://github.com/JCSDA/spack-stack/pull/1192) More updates for Intel oneAPI and consolidation of common/modules*.yaml Jul 29, 2024
@climbfuji climbfuji marked this pull request as ready for review July 29, 2024 10:59
…eature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA I think this is ready for your review (and testing if inclined to do so)

@climbfuji climbfuji merged commit 8aef240 into JCSDA:develop Aug 5, 2024
8 checks passed
@climbfuji climbfuji deleted the feature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler branch August 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants