-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More updates for Intel oneAPI and consolidation of common/modules*.yaml #1200
Merged
climbfuji
merged 25 commits into
JCSDA:develop
from
climbfuji:feature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
Aug 5, 2024
Merged
More updates for Intel oneAPI and consolidation of common/modules*.yaml #1200
climbfuji
merged 25 commits into
JCSDA:develop
from
climbfuji:feature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gcc-openblas environments (py-numpy, gcc-runtime)
…d duplicate packages
…eature/set_env_compiler
…pport for setting compiler for 'spack stack create env'
…eature/set_env_compiler
…ubuntu-ci-x86_64-*.yaml
…eature/set_env_compiler
…dules.py and spack-ext/lib/jcsda-emc/spack-stack/tests/test_stack_create.py
…eature/set_env_compiler
…eature/set_env_compiler
…eature/set_env_compiler
…eature/set_env_compiler
…ji/spack-stack into feature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
…eature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
srherbener
approved these changes
Jul 29, 2024
…les_based_on_feature_set_env_compiler
…eature/oneapi_blackpearl_and_common_modules_based_on_feature_set_env_compiler
@AlexanderRichert-NOAA I think this is ready for your review (and testing if inclined to do so) |
AlexanderRichert-NOAA
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the following changes:
Based on the functionality to merge
modules_${LMOD_OR_TCL}.yaml
withmodules.yaml
, strip out the common settings frommoduels_lmod.yaml
andmodules_tcl.yaml
and put them inmodules.yaml
.Additional updates for building the full unified environment with the oneAPI C/C++ compilers:
gmake
,libbsd
,libm
to modules exclude listblackpearl
site config (once this all works, it can be moved tocommon/packages_oneapi.yaml
): buildbison
,gmake
,libm
,libbsd
withgcc
. That's becausebison
doesn't build withoneapi
(it builds but produces garbage, see bison miscompiled with %oneapi spack/spack#37172)In
configs/templates/unified-dev/spack.yaml
: excludejedi-tools-env
andai-env
foroneapi
, similar to what's done forintel
(this was also done in a previous PR, therefore just cleaning up the comments in the file).With these changes, the unified environment builds with
[email protected]
with the exception ofwgrib2
(see #967 and #1199)Testing
oneapi
andgcc
Applications affected
n/a
Systems affected
Nautilus and Blackpearl - these are the only sites that have
oneapi
compilers configuredDependencies
Issue(s) addressed
More steps towards #912
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.