-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge spack develop as of 2024/05/09 into spack-stack-dev #1109
Merge spack develop as of 2024/05/09 into spack-stack-dev #1109
Conversation
…ing' can now be False instead of an empty dictionary
…ges.yaml with new versions and bug fixes for unified-env build
…eature/merge_spack_develop_into_spack_stack_dev_20240509
d8116e6
to
ba3ffb1
Compare
…o avoid hdf-eos2 build failures
configs/common/packages.yaml
Outdated
@@ -7,6 +7,8 @@ | |||
fftw-api: [fftw] | |||
gl: [opengl] | |||
glu: [openglu] | |||
# DH* CHECK IF NEEDED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self. Remove
@@ -5,5 +5,8 @@ packages: | |||
buildable: false | |||
libiconv: | |||
buildable: false | |||
# DH* CHECK IF NEEDED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self - check
FWIW I'm getting a bunch of the following when concretizing on Hera: ==> Warning: cannot detect libc from intel@=18.0.5.274. The compiler will not be used during concretization.
==> Warning: cannot detect libc from gcc@=4.4.7. The compiler will not be used during concretization. Can we remove those compilers anyway (not in this PR, but before the next release)? |
Absolutely! A site config cleanup before the 1.8.0 release would be a good thing, |
@AlexanderRichert-NOAA Let's incorporate any site specific changes in this PR. Regarding netcdf-cxx4, please see the link above to the issue I created. We should consider reverting to the old and proven autotools build in our fork until that is resolved. |
I'm fine with that re: netcdf-cxx4. Do you want to go ahead and revert the recipe in the spack PR if you haven't already? |
I reverted netcdf-cxx4 back to the version we had before the update |
…eature/merge_spack_develop_into_spack_stack_dev_20240509
@AlexanderRichert-NOAA @RatkoVasic-NOAA I would like to merge this PR this week if possible before I go on leave next week. Do you think that is feasible? It built straight out of the box on Nautilus with [email protected] after the netcdf-cxx4 build tool reversal. |
Yes. Do you want to merge climbfuji#7? I'll go ahead and approve since everything else looks good to me. |
Yes, thanks very much! |
Summary
This PR updates our spack branch to spack develop as of 2024/05/09 (spack 0.22.0.dev0 (4154b2d83f87ae1408ceb604d6b9d5fee444f866)). See JCSDA/spack#432 for details.
This update requires a few bug fixes in our common and site configs, part of this PR.
Testing
Describe the testing done for this PR.
Applications affected
All
Systems affected
All
Dependencies
Issue(s) addressed
n/a
Checklist